Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:121029
Date: Sun, 10 Sep 2023 14:35:24 +0100
To: internals@lists.php.net
User-Agent: K-9 Mail for Android
In-Reply-To: <af50edc5-c931-4aaf-9729-702d40fbadff@gmail.com>
References: <af50edc5-c931-4aaf-9729-702d40fbadff@gmail.com>
Message-ID: <525DC2B4-989F-4E26-AC13-F936FF25DF2F@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain;
 charset=utf-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PHP-DEV] Proposal: $options argument for SimpleXMLElement::asXML
From: rowan.collins@gmail.com (Rowan Tommins)

On 9 September 2023 21:05:37 BST, Niels Dossche <dossche=2Eniels@gmail=2Eco=
m> wrote:
>Hi internals
>
>I came across https://bugs=2Ephp=2Enet/bug=2Ephp?id=3D67387=2E
>Passing the option in via the constructor doesn't work because the constr=
uctor only allows parser options=2E
>We can implement support for options (such as LIBXML_NOXMLDECL, LIBXML_SA=
VE_NOEMPTYTAG) by adding an (optional) argument to the asXML function: `?in=
t $options =3D 0`=2E

In principle, I agree that that makes a lot of sense=2E



>This would be a BC break, because userland classes extending from SimpleX=
MLElement *and* overriding asXML would have to change the signature of asXM=
L=2E

Ah, that's a pain=2E I can think of two solutions that avoid the BC break,=
 but neither are great:

1) Create a new method, e=2Eg=2E asXmlWithOptions()=2E No BC break unless =
someone happens to have a method of that name on their sub-class, but an aw=
kward name in the long-term=2E
2) Allow output options on the constructor, and carry them forwards throug=
h instances until asXml() is called=2E No BC break, but not very intuitive=
=2E

Actually, it occurs to me that if you think of the options as stateful on =
the instance, a third option is to have a setOutputOptions() method to be c=
alled before asXml()=2E Still a bit clunky though=2E

Regards,

--=20
Rowan Tommins
[IMSoP]