Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:121027 Return-Path: Delivered-To: mailing list internals@lists.php.net Received: (qmail 4855 invoked from network); 9 Sep 2023 20:05:42 -0000 Received: from unknown (HELO php-smtp4.php.net) (45.112.84.5) by pb1.pair.com with SMTP; 9 Sep 2023 20:05:42 -0000 Received: from php-smtp4.php.net (localhost [127.0.0.1]) by php-smtp4.php.net (Postfix) with ESMTP id 820F8180083 for ; Sat, 9 Sep 2023 13:05:41 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on php-smtp4.php.net X-Spam-Level: X-Spam-Status: No, score=-0.7 required=5.0 tests=BAYES_05,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.2 X-Spam-ASN: AS15169 209.85.128.0/17 X-Spam-Virus: No X-Envelope-From: Received: from mail-wr1-f47.google.com (mail-wr1-f47.google.com [209.85.221.47]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature ECDSA (P-256) server-digest SHA256) (No client certificate requested) by php-smtp4.php.net (Postfix) with ESMTPS for ; Sat, 9 Sep 2023 13:05:41 -0700 (PDT) Received: by mail-wr1-f47.google.com with SMTP id ffacd0b85a97d-31f8a05aa24so824953f8f.1 for ; Sat, 09 Sep 2023 13:05:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1694289939; x=1694894739; darn=lists.php.net; h=content-transfer-encoding:subject:from:to:content-language :user-agent:mime-version:date:message-id:from:to:cc:subject:date :message-id:reply-to; bh=dJNZ2FqXAquuDN6aV3EyNoBK1VuycFtaBmLC0RcDuQg=; b=BMnq4BmB4Vk3LUVFZ+DLQ2z9yoJdnXZmQD+1tnYmUN4F0f/t6vODBoNdhYOQSXn1So rngTG602d/mDb2pIO/zu9MiC+lexoZdTsjpcBlsTLTI1X4sDyP7ZVQqbnvoZcq3Zx8or 7O0VgBDu1OItgd+/55E/5wgZeRU4zOuAETzxH7nCgV5aRUQw5ab0cRM+AZU/xbGedJbz iEGuOfY9/ECUMOPKpNgsaR5rvqxjfh1atLNxIzvx9kPsk6t7wb3xGiuPhJU5Wffa5tuD mORnqwTOUAoAlSLvQOmWEsa2J+SDu9NcZMY6OSqeKzhkUpDiTUrAtTey4UrvOTj8jQV5 v+QQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694289939; x=1694894739; h=content-transfer-encoding:subject:from:to:content-language :user-agent:mime-version:date:message-id:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=dJNZ2FqXAquuDN6aV3EyNoBK1VuycFtaBmLC0RcDuQg=; b=QcHkfCbIe9HZ8Pgk/7YUVLcG8bKo+tdgRduWJ/T4WSi1WKqk/+a9ouJZj834uTu6Em zdwWgWUNP1gYU0EQtz0TM3eyO8YY7RECz95/LgLK18bf8v8/9cv8mAsrfzggyIR3jZ9H FSZWvanixklIlottIiGtjxiGGg6eITwu/8GjNBEOTGX9hcTY85jYgS+NZx+m4L+7oW4Q w6ySgZG9Q/lt8u9upRC9cUEHpnbrTGCJYimxH1dHViqlmRenNf1JOV3LsFAIgaWX4Q1K cEc75NOSDmtcsz45EP5tIRbsE3VeS5lehSKiTxA8MIkIHytCjxgWDzIwXrnARp+lmViK J1BQ== X-Gm-Message-State: AOJu0YzHDBkDJGOUXxY0PqIOsZdr5n3gx2ImB48C0uUEIUE9WoY0tq+V sa/8GRVahPv28XlkYa3rb0W/ioyeV4U= X-Google-Smtp-Source: AGHT+IFAoRRwJMY/rOxy4PWLaLHBHNCZRgCzlheWpKOROwqlKR/V2aE8Yqt6Jqod7hKcvcibLeX7/g== X-Received: by 2002:a5d:595f:0:b0:31d:3669:1c55 with SMTP id e31-20020a5d595f000000b0031d36691c55mr4573325wri.65.1694289939343; Sat, 09 Sep 2023 13:05:39 -0700 (PDT) Received: from [192.168.0.59] (178-117-137-225.access.telenet.be. [178.117.137.225]) by smtp.gmail.com with ESMTPSA id w13-20020a056402128d00b005227e53cec2sm2531184edv.50.2023.09.09.13.05.38 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 09 Sep 2023 13:05:38 -0700 (PDT) Message-ID: Date: Sat, 9 Sep 2023 22:05:37 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: PHP Internals Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Proposal: $options argument for SimpleXMLElement::asXML From: dossche.niels@gmail.com (Niels Dossche) Hi internals I came across https://bugs.php.net/bug.php?id=67387. Passing the option in via the constructor doesn't work because the constructor only allows parser options. We can implement support for options (such as LIBXML_NOXMLDECL, LIBXML_SAVE_NOEMPTYTAG) by adding an (optional) argument to the asXML function: `?int $options = 0`. This would be a BC break, because userland classes extending from SimpleXMLElement *and* overriding asXML would have to change the signature of asXML. It's not hard at all to implement this functionality, but I want to ask first if there's any opinions on this before I write up an RFC. Thanks Niels