Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:121017
MIME-Version: 1.0
References: <CAPTD5yEcwBNUe2Y9vvmHaigFtvRixJ0anTuLk4zXOKvBhrUOig@mail.gmail.com>
 <7f23f0ac-bba6-5997-b737-2a252205cf85@bastelstu.be> <CAAwdEzDGa+16bc0Hhmnzau6vkGpfRFqiRetw7V7KGbjsTyS8Cg@mail.gmail.com>
 <CAMrTa2ECWas1MwsUhsLjDUpj1dxikBdCj4CVwcqUFi+2hT-tyA@mail.gmail.com>
In-Reply-To: <CAMrTa2ECWas1MwsUhsLjDUpj1dxikBdCj4CVwcqUFi+2hT-tyA@mail.gmail.com>
Date: Fri, 8 Sep 2023 18:10:29 +0300
Message-ID: <CAAwdEzA087iQRdj6WAcV9h2AbEf2jcNTyZFX_vMwFqiuh8HNsQ@mail.gmail.com>
To: PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="0000000000009a556a0604da619a"
Subject: Re: [PHP-DEV] [RFC] [Discussion] Add 4 new rounding modes to round() function
From: drealecs@gmail.com (=?UTF-8?Q?Alexandru_P=C4=83tr=C4=83nescu?=)

--0000000000009a556a0604da619a
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Thu, Sep 7, 2023 at 11:10=E2=80=AFPM Jordan LeDoux <jordan.ledoux@gmail.=
com>
wrote:

>
> As someone who maintains a math library in PHP that has its own expanded
> rounding implementation, I will politely disagree. Away from zero, toward=
s
> zero, towards positive infinity, and towards negative infinity are
> completely and utterly unambiguous and provide the developer with precise
> control over what behavior they want. I don't see a reason to use somethi=
ng
> that we KNOW is ambiguous when we're designing it.
>
>
I agree. My main point was consistency.


On Tue, Sep 5, 2023 at 1:34=E2=80=AFAM Jorg Sowa <jorg.sowa@gmail.com> wrot=
e:

> Thank you all for the comments. The naming brought some constructive
> discussion.
>
> My preferred solution would be inconsistent PHP_ROUND_AWAY_FROM_ZERO and
> PHP_ROUND_TOWARD_ZERO as those are friendlier to the most of developers a=
nd
> are not possible to mistake with other modes. I would go even one step
> further and create aliases for NumberFormatter constants to have the nami=
ng
> consistent.
>
>
Yes, this is a great way to achieve consistency, adding aliases also in
NumberFormatter.

Thank you,
Alex

--0000000000009a556a0604da619a--