Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:120990
MIME-Version: 1.0
References: <EAF408F0-7D02-4245-8707-A9257C07355E@sakiot.com>
In-Reply-To: <EAF408F0-7D02-4245-8707-A9257C07355E@sakiot.com>
Date: Wed, 6 Sep 2023 13:22:07 +0100
Message-ID: <CAFPFaM+6MniUCEkyLc5M0KNPN5qzJzn8BxZ6aH22CfO60RFS+Q@mail.gmail.com>
To: Saki Takamachi <saki@sakiot.com>
Cc: internals@lists.php.net
Content-Type: multipart/alternative; boundary="0000000000006c2f690604afcb5a"
Subject: Re: [PHP-DEV] Deprecate PDO::ATTR_ERRMODE [Proposed RFC]
From: george.banyard@gmail.com ("G. P. B.")

--0000000000006c2f690604afcb5a
Content-Type: text/plain; charset="UTF-8"

On Tue, 29 Aug 2023 at 14:52, Saki Takamachi <saki@sakiot.com> wrote:

> Hi, internals.
>
> I thought about various things to improve the current situation where
> `PDO::ATTR_ERRMODE` is not working very smartly.
>
> Exceptions may be thrown regardless of the setting of `PDO::ATTR_ERRMODE`.
> https://www.php.net/manual/en/pdo.rollback.php#refsect1-pdo.rollback-errors
>
> Another annoyance is that `PDO::ERRMODE_SILENT` sometimes gives a warning.
> This is an undocumented phenomenon, and it's a 19-year-old vintage bug.
>
> https://github.com/php/php-src/blob/223fb08819967b3063610289a5783944a85d6d65/ext/pdo/pdo_dbh.c#L74
>
> Based on these, I feel that the reliability of the attribute value
> PDO::ATTR_ERRMODE is low and there is not much meaning in its existence as
> an attribute value.
>
> Since the default behavior became `PDO::ERRMODE_EXCEPTION` in PHP8.0.0, I
> think it would be better to abolish it rather than leave it halfway.
>
> I think this is a big change, so I'm assuming 9.x+ even if it's
> implemented.
> I will do the implementation myself.
>
> Please let me know what you think.
> Thank you.
>
> Saki
>

I don't know about removing the silent mode altogether, but I think the
warning version is pretty useless.
However, if we are going to remove it, it would be nice to have this done
consistently across all bundled extensions.
From the top of my head, I know SQLite3 and the Intl extension also have
such flags, and possibly the DOM extension too.

Best regards.

George P. Banyard

--0000000000006c2f690604afcb5a--