Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:120983
MIME-Version: 1.0
References: <CAPTD5yEcwBNUe2Y9vvmHaigFtvRixJ0anTuLk4zXOKvBhrUOig@mail.gmail.com>
 <7f23f0ac-bba6-5997-b737-2a252205cf85@bastelstu.be> <CAAwdEzDGa+16bc0Hhmnzau6vkGpfRFqiRetw7V7KGbjsTyS8Cg@mail.gmail.com>
 <9a19120d-1767-6214-c728-c67a9a98f977@bastelstu.be>
In-Reply-To: <9a19120d-1767-6214-c728-c67a9a98f977@bastelstu.be>
Date: Tue, 5 Sep 2023 00:34:39 +0200
Message-ID: <CAPTD5yHQnP8RQJVZg4MTPkHk6yVhnr+rqdffNaE6_TM_zb9+NA@mail.gmail.com>
To: =?UTF-8?Q?Tim_D=C3=BCsterhus?= <tim@bastelstu.be>
Cc: =?UTF-8?Q?Alexandru_P=C4=83tr=C4=83nescu?= <drealecs@gmail.com>, 
	PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="0000000000005659c10604901eeb"
Subject: Re: [PHP-DEV] [RFC] [Discussion] Add 4 new rounding modes to round() function
From: jorg.sowa@gmail.com (Jorg Sowa)

--0000000000005659c10604901eeb
Content-Type: text/plain; charset="UTF-8"

Thank you all for the comments. The naming brought some constructive
discussion.

My preferred solution would be inconsistent PHP_ROUND_AWAY_FROM_ZERO and
PHP_ROUND_TOWARD_ZERO as those are friendlier to the most of developers and
are not possible to mistake with other modes. I would go even one step
further and create aliases for NumberFormatter constants to have the naming
consistent.

> Introducing a brand-new RoundingMode enum (using union types) I
> suggested in my first email would nicely solve the naming problem and
> would also make the API more obvious to use due to stronger typing in
> the long run.

That's also interesting idea and I would push it, however I'm afraid about
the naming of namespace. I recollect some of the RFCs were rejected simply
because of the namespace. If there is a guideline for the namespace of core
functions I would willingly get familiar to it. Otherwise, I don't want to
open Pandora box only because of the namespace of Enum. It would also bring
BC to the function, unless we would accept both enum and old constants.

Kind regards,
Jorg

--0000000000005659c10604901eeb--