Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:120976
MIME-Version: 1.0
References: <CAPTD5yEcwBNUe2Y9vvmHaigFtvRixJ0anTuLk4zXOKvBhrUOig@mail.gmail.com>
 <7f23f0ac-bba6-5997-b737-2a252205cf85@bastelstu.be>
In-Reply-To: <7f23f0ac-bba6-5997-b737-2a252205cf85@bastelstu.be>
Date: Sun, 3 Sep 2023 18:50:48 +0300
Message-ID: <CAAwdEzDGa+16bc0Hhmnzau6vkGpfRFqiRetw7V7KGbjsTyS8Cg@mail.gmail.com>
To: =?UTF-8?Q?Tim_D=C3=BCsterhus?= <tim@bastelstu.be>
Cc: Jorg Sowa <jorg.sowa@gmail.com>, PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="000000000000725b360604765ce3"
Subject: Re: [PHP-DEV] [RFC] [Discussion] Add 4 new rounding modes to round() function
From: drealecs@gmail.com (=?UTF-8?Q?Alexandru_P=C4=83tr=C4=83nescu?=)

--000000000000725b360604765ce3
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi!

On Sun, Sep 3, 2023 at 3:14=E2=80=AFPM Tim D=C3=BCsterhus <tim@bastelstu.be=
> wrote:

>
> The RFC mentions already has a section with regard to naming:
>
>  > Why not the names PHP_ROUND_UP and PHP_ROUND_DOWN
>
> I generally agree with the argument in favor of the names you've chosen.
> However they are inconsistent with the existing 'PHP_ROUND_HALF_UP' /
> DOWN constants.
>
> I don't want to create extra work for you, but I wonder if additionally
> one of the following should be done:
>
> - Creating PHP_ROUND_HALF_AWAY_FROM_ZERO as an alias for
> PHP_ROUND_HALF_UP (and likewise for HALF_DOWN).
>
>
I believe consistency is important and using UP for "away from zero" and
DOWN for "towards zero" sounds good to me. That was so far used
consistently everywhere, as far as I'm aware.
Documentation is very clear about what they mean, and you can always think
that both positive infinity and negative infinity are up while zero is down=
.

Yes, we can have some extra constants for the four ones that contain "up"
or "down" with "away from zero" and "towards zero", but I find it
unnecessary.

Regards,
Alex

--000000000000725b360604765ce3--