Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:120975
Message-ID: <7f23f0ac-bba6-5997-b737-2a252205cf85@bastelstu.be>
Date: Sun, 3 Sep 2023 14:13:59 +0200
MIME-Version: 1.0
Content-Language: en-US
To: Jorg Sowa <jorg.sowa@gmail.com>, PHP internals <internals@lists.php.net>
References: <CAPTD5yEcwBNUe2Y9vvmHaigFtvRixJ0anTuLk4zXOKvBhrUOig@mail.gmail.com>
In-Reply-To: <CAPTD5yEcwBNUe2Y9vvmHaigFtvRixJ0anTuLk4zXOKvBhrUOig@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Subject: Re: [PHP-DEV] [RFC] [Discussion] Add 4 new rounding modes to round()
 function
From: tim@bastelstu.be (=?UTF-8?Q?Tim_D=c3=bcsterhus?=)

Hi

On 9/2/23 21:33, Jorg Sowa wrote:
> RFC: https://wiki.php.net/rfc/new_rounding_modes_to_round_function

The RFC mentions already has a section with regard to naming:

 > Why not the names PHP_ROUND_UP and PHP_ROUND_DOWN

I generally agree with the argument in favor of the names you've chosen. 
However they are inconsistent with the existing 'PHP_ROUND_HALF_UP' / 
DOWN constants.

I don't want to create extra work for you, but I wonder if additionally 
one of the following should be done:

- Creating PHP_ROUND_HALF_AWAY_FROM_ZERO as an alias for 
PHP_ROUND_HALF_UP (and likewise for HALF_DOWN).
- Adding an entirely new \RoundingMode enum with clear names for all 
variants. I feel like documenting such an enum with a dedicated page 
would be easier compared to the PHP_ROUND_* constants which are not 
directly related, except for the prefix.

Furthermore there will be another inconsistency by not having the 
CEIL/FLOOR variants for the halfway point (i.e. half towards positive 
infinity and half towards negative infinity).

Best regards
Tim Düsterhus