Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:120947
Content-Type: text/plain;
	charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.600.7\))
In-Reply-To: <DB4DCFB3-54EB-433B-AC1A-C1F923DDEFC3@sakiot.com>
Date: Tue, 29 Aug 2023 17:48:51 +0200
Cc: PHP internals <internals@lists.php.net>
Content-Transfer-Encoding: quoted-printable
Message-ID: <5B8A7736-9A2A-47E1-B410-4D734DC75EBE@gmail.com>
References: <4406C50C-18FF-4F20-BA7B-206E86610CCC@sakiot.com>
 <245BD1CC-7D54-4CBE-9640-5C8FF5225617@gmail.com>
 <DB4DCFB3-54EB-433B-AC1A-C1F923DDEFC3@sakiot.com>
To: Saki Takamachi <saki@sakiot.com>
Subject: Re: [PHP-DEV] Apply strict_types to internal functions
From: claude.pache@gmail.com (Claude Pache)



> Le 29 ao=C3=BBt 2023 =C3=A0 15:19, Saki Takamachi <saki@sakiot.com> a =
=C3=A9crit :
>=20
>> Hi,
>>=20
>> The larger issue is that higher-order functions do not inherit the =
`strict_types` mode from its calling code, and this is not specific to =
internal functions.
>>=20
>> If you intend to change that for internal functions (with proper =
deprecation period, of course), you might consider making such a =
behaviour also possible for userland functions (probably using some =
opt-in); so that future higher-order internal functions do not become =
impossible to polyfill.
>>=20
>> =E2=80=94Claude
>=20
> Hi, thank you for confirming.
>=20
> If you simply put the problem you pointed out in the code, would it be =
something like this?
> https://gist.github.com/SakiTakamachi/8292dbfe92a2029a6c7b506b12296b7d
>=20
> Admittedly, I don't think this is intuitive either.

That might not be intuitive to you, but it follows directly from the =
specified semantics: whether a function is called in `strict_types` mode =
or not, depends only on where the function is called. I personally doubt =
that there is an easy way to adjust the rule in order to make it both =
=E2=80=9Cintuitive=E2=80=9D and simple.

>=20
> [...]
>=20
> When considering the inheritance of strict_types, I think that it =
should be an attribute that can be set in =E2=80=9Cphp.ini" instead of =
being specified for each file.
>=20
> What do you think?

Beware that there are many third-party packages that have not opted for =
`strict_types=3D1`; if you enable that mode globally, you might make =
those packages malfunction.

As I have just checked, among the packages I=E2=80=99ve installed via =
composer, there are more packages that do not use `strict_types=3D1`, =
than packages that use it. Among those that don=E2=80=99t use =
`strict_types`, the following ones are fairly common:

google/apiclient
league/oauth2-client
michelf/php-markdown
microsoft/microsoft-graph
phpmailer/phpmailer
phpoffice/phpspreadsheet
phpseclib/phpseclib

=E2=80=94Claude