Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:120942
Content-Type: text/plain;
	charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.600.7\))
In-Reply-To: <4406C50C-18FF-4F20-BA7B-206E86610CCC@sakiot.com>
Date: Tue, 29 Aug 2023 14:16:49 +0200
Cc: internals@lists.php.net
Content-Transfer-Encoding: quoted-printable
Message-ID: <245BD1CC-7D54-4CBE-9640-5C8FF5225617@gmail.com>
References: <4406C50C-18FF-4F20-BA7B-206E86610CCC@sakiot.com>
To: Saki Takamachi <saki@sakiot.com>
Subject: Re: [PHP-DEV] Apply strict_types to internal functions
From: claude.pache@gmail.com (Claude Pache)



> Le 29 ao=C3=BBt 2023 =C3=A0 02:46, Saki Takamachi <saki@sakiot.com> a =
=C3=A9crit :
>=20
> Hello.
>=20
> I=E2=80=99m Saki Takamachi.
>=20
> Inspired by the issue below, I'm thinking of proposing this RFC.
> https://github.com/php/php-src/issues/12055
>=20
> As the documentation below states, PHP's internal functions currently =
ignore strict_types.
> =
https://www.php.net/manual/en/language.types.declarations.php#language.typ=
es.declarations.strict
>=20
> I think the current spec is not intuitive,
> so I propose changing the behavior of the macro =
ZEND_ARG_USES_STRICT_TYPES() to allow internal functions to accept =
strict_types.
>=20
> I plan to make changes in zend_compile.h and zend_compile.c and do the =
changes myself, I haven't written any tests yet, but I'm thinking about =
making changes like this.
> https://github.com/SakiTakamachi/php-src/pull/1
>=20
> As per How To Create an RFC, I will first try to gauge response to =
this proposal on the mailing list.
>=20
> Thank you
>=20
> Saki Takamachi


Hi,

The larger issue is that higher-order functions do not inherit the =
`strict_types` mode from its calling code, and this is not specific to =
internal functions.

If you intend to change that for internal functions (with proper =
deprecation period, of course), you might consider making such a =
behaviour also possible for userland functions (probably using some =
opt-in); so that future higher-order internal functions do not become =
impossible to polyfill.

=E2=80=94Claude=