Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:120941
MIME-Version: 1.0
References: <4406C50C-18FF-4F20-BA7B-206E86610CCC@sakiot.com>
In-Reply-To: <4406C50C-18FF-4F20-BA7B-206E86610CCC@sakiot.com>
Date: Tue, 29 Aug 2023 09:41:34 +0200
Message-ID: <CANS-=pdSpDccyxQBwpJVVSE8acNY+aaXt4aa_TC2Bu4+_z_SMA@mail.gmail.com>
To: Saki Takamachi <saki@sakiot.com>
Cc: internals@lists.php.net
Content-Type: multipart/alternative; boundary="0000000000002ffd5d06040af264"
Subject: Re: [PHP-DEV] Apply strict_types to internal functions
From: kjarli@gmail.com (Lynn)

--0000000000002ffd5d06040af264
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Tue, Aug 29, 2023 at 2:46=E2=80=AFAM Saki Takamachi <saki@sakiot.com> wr=
ote:

> Hello.
>
> I=E2=80=99m Saki Takamachi.
>
> Inspired by the issue below, I'm thinking of proposing this RFC.
> https://github.com/php/php-src/issues/12055
>
> As the documentation below states, PHP's internal functions currently
> ignore strict_types.
>
> https://www.php.net/manual/en/language.types.declarations.php#language.ty=
pes.declarations.strict
>
> I think the current spec is not intuitive,
> so I propose changing the behavior of the macro
> ZEND_ARG_USES_STRICT_TYPES() to allow internal functions to accept
> strict_types.
>
> I plan to make changes in zend_compile.h and zend_compile.c and do the
> changes myself, I haven't written any tests yet, but I'm thinking about
> making changes like this.
> https://github.com/SakiTakamachi/php-src/pull/1
>
> As per How To Create an RFC, I will first try to gauge response to this
> proposal on the mailing list.
>
> Thank you
>
> Saki Takamachi
>

Heya!

I was not aware that strict types didn't work here. While I'm 100% behind
the idea, I am afraid that changing this will break code in currently
strict files where the assumption was made that it already worked like
that. It would probably have to give deprecation notices first, and then
possibly a warning or removal in the next major to be feasible.

--0000000000002ffd5d06040af264--