Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:120934
MIME-Version: 1.0
Date: Thu, 24 Aug 2023 21:21:28 +0100
Message-ID: <CAGBsUre-Oq298AanvLChoFU1W-R8opkEB82U8unxmhBXxvxPFw@mail.gmail.com>
To: PHP internals <internals@lists.php.net>
Content-Type: text/plain; charset="UTF-8"
Subject: Adding new error to mysql_stmt_data_seek
From: tekiela246@gmail.com (Kamil Tekiela)

Hi Internals,

This is in relation to PR #10419: https://github.com/php/php-src/pull/10419
I was hoping to get it merged into PHP 8.3, but there were some
objections. I would like to receive some opinions from the broader
community.

According to the MySQL standard mysql_stmt_data_seek should be a void
function [1], but in mysqlnd it was always returning a bool; it
returns false when used in invalid context. Since we no longer support
libmysql, we are no longer restricted to not knowing if this action
failed. Checking for an error condition and informing the mysqli user
about incorrect usage makes sense.
The only time this function returns false is if it's used on PS
without a buffered result set, hence the text of the error message. It
is always a developer error due to invalid use of this function.
Letting the developer know they used the function incorrectly would be
a welcomed addition, in my opinion.

What do you think?

[1]: https://dev.mysql.com/doc/c-api/8.1/en/mysql-stmt-data-seek.html

Regards,
Kamil