Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:120879
Date: Thu, 3 Aug 2023 20:40:38 +0200
To: =?utf-8?Q?Bj=C3=B6rn_Larsson?= <internals@lists.php.net>, Ollie Read
 <php@ollie.codes>
Message-ID: <3a8515c3-6486-4157-b909-eafada179e8f@Spark>
In-Reply-To: <30d0a0f2-95d5-4a02-aae3-e63eda3a8e13@app.fastmail.com>
References: <19f70187-09d5-4f60-ba01-265f2e97f7cc@app.fastmail.com>
 <CA+p1FaaOQRj+h541_BwoevkkV6r+bpCRdX0-kaP9V_9-9xTKaw@mail.gmail.com>
 <0052fa6d-b01c-4965-bea7-0b735bc1dc22@Spark>
 <CAFPFaMKdgtKdcTRXU3Dy4hEHmU6=qKk+k8ZDizrobE0GCq73YQ@mail.gmail.com>
 <3ad96046-1737-4f64-8e51-34f6635579d0@Spark>
 <30d0a0f2-95d5-4a02-aae3-e63eda3a8e13@app.fastmail.com>
MIME-Version: 1.0
Content-Type: multipart/alternative; boundary="64cbf4b9_5b8d8c12_ce2"
Subject: Re: [PHP-DEV] New reflection methods for working with
 attributes
From: robin.chalas@gmail.com (Robin Chalas)

--64cbf4b9_5b8d8c12_ce2
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline

> In that case, are you happy for me to PR the other two methods I sugges=
ted, or would you like to handle that=3F

Please go ahead=21 Thanks for caring.
And if you already have the patch ready for hasAttribute() too but just c=
are enough to leave it to the wanna-be-first-time-contributor that I am, =
please consider sharing it to me so that I can compare with what I have o=
nce I=E2=80=99m back from vacation next week (and either come back to you=
 with questions or incline myself :)). Or I=E2=80=99ll send you mine for =
early review when I=E2=80=99m back to keyboard if you=E2=80=99re ok.

Cheers

-- Robin Chalas
Le 3 ao=C3=BBt 2023 =C3=A0 20:20 +0200, Ollie Read <php=40ollie.codes>, a=
 =C3=A9crit :
>
> > Alright, I will just ship the PR for =60hasAttribute()=60 then.
> > Thanks for the hints and feedback.
> > And sorry for the bad posting style, I hope this one is ok.
>
> In that case, are you happy for me to PR the other two methods I sugges=
ted, or would you like to handle that=3F
>
> ---
> Best Regards,
> *Ollie Read*

--64cbf4b9_5b8d8c12_ce2--