Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:120876
Message-ID: <33580689-7f15-e8d4-b2b7-a62ee6926fdc@demon-angel.eu>
Date: Thu, 3 Aug 2023 10:28:02 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.13.0
Content-Language: nl
To: internals@lists.php.net
References: <CAPTD5yFf-ue+Hy7O8pS035xoQDYED7Oc1cVVy-cWEHQjVGYjxA@mail.gmail.com>
In-Reply-To: <CAPTD5yFf-ue+Hy7O8pS035xoQDYED7Oc1cVVy-cWEHQjVGYjxA@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] Introducing 2 new modes to round function
From: mark@demon-angel.eu (Mark Baker)

Once upon a many years ago: https://github.com/php/php-src/pull/1658


It will be nice to see it finally get and implementation


On 21/07/2023 21:26, Jorg Sowa wrote:
> Hello internals!
>
> I would like to propose introducing two new modes to the function
> `round()`: PHP_ROUND_DOWN and PHP_ROUND_UP.
>
> Those modes are highly requested as you can see by the comments on round
> documentation page. First comment mentioning about those modes has 309
> votes as of today. Introducing those 2 modes would be complementing to the
> rounding in this function.
>
> Round documentation: https://www.php.net/manual/en/function.round.php
> My implementation: https://github.com/php/php-src/pull/11741
>
> I'm not sure if such minor improvement requires RFC, but as someone may
> have some concerns I create this thread to get your feedback.
>
> Kind regards,
> Jorg
>
-- 
Mark Baker