Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:120857
MIME-Version: 1.0
References: <CAPTD5yFf-ue+Hy7O8pS035xoQDYED7Oc1cVVy-cWEHQjVGYjxA@mail.gmail.com>
In-Reply-To: <CAPTD5yFf-ue+Hy7O8pS035xoQDYED7Oc1cVVy-cWEHQjVGYjxA@mail.gmail.com>
Date: Fri, 21 Jul 2023 21:38:03 +0200
Message-ID: <CADyq6sLGTQWO1fAEq+88_738dLyS_gYNYiCckXJGZrek_sw1kA@mail.gmail.com>
To: Jorg Sowa <jorg.sowa@gmail.com>
Cc: PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="000000000000f1629e060104678d"
Subject: Re: [PHP-DEV] Introducing 2 new modes to round function
From: ocramius@gmail.com (Marco Pivetta)

--000000000000f1629e060104678d
Content-Type: text/plain; charset="UTF-8"

Hey Jorg,

What is the reason for using this over these?

 * https://www.php.net/manual/en/function.ceil.php
 * https://www.php.net/manual/en/function.floor.php



On Fri, 21 Jul 2023, 21:26 Jorg Sowa, <jorg.sowa@gmail.com> wrote:

> Hello internals!
>
> I would like to propose introducing two new modes to the function
> `round()`: PHP_ROUND_DOWN and PHP_ROUND_UP.
>
> Those modes are highly requested as you can see by the comments on round
> documentation page. First comment mentioning about those modes has 309
> votes as of today. Introducing those 2 modes would be complementing to the
> rounding in this function.
>
> Round documentation: https://www.php.net/manual/en/function.round.php
> My implementation: https://github.com/php/php-src/pull/11741
>
> I'm not sure if such minor improvement requires RFC, but as someone may
> have some concerns I create this thread to get your feedback.
>
> Kind regards,
> Jorg
>

--000000000000f1629e060104678d--