Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:120816 Return-Path: Delivered-To: mailing list internals@lists.php.net Received: (qmail 69615 invoked from network); 14 Jul 2023 14:01:09 -0000 Received: from unknown (HELO php-smtp4.php.net) (45.112.84.5) by pb1.pair.com with SMTP; 14 Jul 2023 14:01:09 -0000 Received: from php-smtp4.php.net (localhost [127.0.0.1]) by php-smtp4.php.net (Postfix) with ESMTP id E55E118050B for ; Fri, 14 Jul 2023 07:01:05 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on php-smtp4.php.net X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=BAYES_50,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE, T_SPF_TEMPERROR autolearn=no autolearn_force=no version=3.4.2 X-Spam-ASN: AS15169 209.85.128.0/17 X-Spam-Virus: No X-Envelope-From: Received: from mail-pg1-f181.google.com (mail-pg1-f181.google.com [209.85.215.181]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature ECDSA (P-256) server-digest SHA256) (No client certificate requested) by php-smtp4.php.net (Postfix) with ESMTPS for ; Fri, 14 Jul 2023 07:01:05 -0700 (PDT) Received: by mail-pg1-f181.google.com with SMTP id 41be03b00d2f7-55b83ae9be2so1524502a12.2 for ; Fri, 14 Jul 2023 07:01:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=team.bumble.com; s=google; t=1689343264; x=1691935264; h=to:subject:message-id:date:from:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=5FhRsQlThyUdZIz79yevsiQtDiqx6VAOAvjNLzksmd4=; b=Uw0ppAfvAkFT0ZTb4vVCMJESQfOi8uXA4jXoDmJWu80Rv+Ip4t7i6Haqb+JPPK4iim ZFkWM75AZ4CglGL0Ac0T98A4pUP/eefJbPBQWML02SBbSt8kVvOjyCQUul4+cgVAwFUy 3lvN70aXN7CBISFtJVWEVaTx92LHjUftI1zUk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689343264; x=1691935264; h=to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=5FhRsQlThyUdZIz79yevsiQtDiqx6VAOAvjNLzksmd4=; b=XhIjl16oaFiARYqfeIj2Ykm2lXm1/VEnjOjQMtb6Zjr+4z+RoELdkfOWjAEKQuT+GE xVVh3CDhVGTuRdcSQ13oaV+Rsot11MPXZadhy9SDb8SMDv1RjH+aqsCm65OfBZxSf60J sAtJ9M5nbocDOi6uZ4qHugbQZIdQGbjqmUS+zM7tpYPICHjGMA89jM6bypNfjSpUN0pS iLAkQ6pR+XXR+rE0rpdGKVF6OuBJeNmhvzACJ0BBCKEeENtJOoP3Pp8shTdcIMGD0aHc dVaEzgBGDbi14CJzfm+3eNb/Sn99ukMOd2aAhM/SFuUSaCCgHla85ls4ciZ0hxhtYZP6 dbVA== X-Gm-Message-State: ABy/qLat5FrXv6J0f8Y92LI7NeQ+iYBL8RDpE2dFms7+lVyo9Pw3xhcc shW1kr+6HD1W4N77EgOSkOySdM/qAekqy5ojkIpyxlDOZ7c673o1iKE= X-Google-Smtp-Source: APBJJlFqNqY0DFp4THQacW3yDYSgpuo6V7/5X/1sOoT4WLF+GQEaafSeO9tAJKktkuAV/18qh6cgCTlplmS+LM//1bI= X-Received: by 2002:a17:90a:db58:b0:263:30d6:dca with SMTP id u24-20020a17090adb5800b0026330d60dcamr3964358pjx.29.1689343263673; Fri, 14 Jul 2023 07:01:03 -0700 (PDT) MIME-Version: 1.0 Reply-To: Mikhail Galanin Date: Fri, 14 Jul 2023 15:00:27 +0100 Message-ID: To: PHP Developers Mailing List Content-Type: text/plain; charset="UTF-8" Subject: freopen() function From: internals@lists.php.net ("Mikhail Galanin via internals") Hi there, I was checking our codebase and realised that we still use the function proposed by Antony a long time ago [1]. I run through the comments and feel like I can address the issues discussed back then. My question is what would be the best way to move forward? Shall I reopen the PR, create new or would it be better to start with a RFC? Links: [1] https://github.com/php/php-src/pull/950 [2] https://linux.die.net/man/3/freopen Thanks