Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:120797
Feedback-ID: i8414410d:Fastmail
User-Agent: Cyrus-JMAP/3.9.0-alpha0-531-gfdfa13a06d-fm-20230703.001-gfdfa13a0
Mime-Version: 1.0
Message-ID: <3d9f4cac-7840-42c9-be9c-e9fc3bcc030a@app.fastmail.com>
In-Reply-To: <906b41e4-dcbd-4a03-9d10-33723ce1c708@Spark>
References: <29da91e9-d649-49c5-a415-46a84d22d531@Spark>
 <906b41e4-dcbd-4a03-9d10-33723ce1c708@Spark>
Date: Wed, 12 Jul 2023 18:04:07 +0000
To: "php internals" <internals@lists.php.net>
Content-Type: text/plain;charset=utf-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PHP-DEV] Reflection*::hasAttribute()
From: larry@garfieldtech.com ("Larry Garfield")

On Wed, Jul 12, 2023, at 3:25 AM, Robin Chalas wrote:
> Hi internals,
>
> It is common attributes to be used as markers. Just like a marker=20
> interface with no methods, such attributes don=E2=80=99t have any para=
meter.
>
> Examples from Symfony:
> - #[Ignore] indicating that a property should be skipped in a=20
> serialization contextl
> - #[Exclude] telling the dependency injection container that a given=20
> class should be skipped from automatic service registration
>
>
> From Doctrine ORM:
> - #[Id] to tell which property of en entity class should be mapped as=20
> primary key
>
> Those are meant to opt in/out some behavior through detection only. Bu=
t=20
> with the current API, such code needs to call `getAttributes()` while=20
> it doesn't care about the returned ReflectionAttribute instances.
> Hence I=E2=80=99m wondering if we could add a `hasAttribute()` method =
to the=20
> reflectors that are targetable by attributes.
>
> Does that make sense?
> If it does, do I need to open an RFC for that feature or is a pull=20
> request be enough?
>
> Anyway, I=E2=80=99d be happy to work on the implementation as a first=20
> contribution to PHP.
> Looking forward to your feedback.
>
> Thanks.
> Robin

I think that would require an RFC.

To clarify, you're proposing to replace this:

count((new ReflectionClass(Beep::class))->getAttributes(Ignore::class)) =
=3D=3D true

with

(new ReflectionClass(Beep::class))->hasAttribute(Ignore::class)

Right?  That doesn't seem like a huge improvement.

--Larry Garfield