Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:120693
MIME-Version: 1.0
References: <CAPyj-LAabBCvrHUTgO4yoJATmvT0N2Kk7ZpwCb=Vo9aRbz7PtQ@mail.gmail.com>
 <CALKiJKoQudehGwZF9OrB=+rpmpz4My7WR3Fx34GUN2XZL9J1nQ@mail.gmail.com> <E7C8FDCD-4333-4D7A-BBB3-C365F9F1D8CA@benramsey.com>
In-Reply-To: <E7C8FDCD-4333-4D7A-BBB3-C365F9F1D8CA@benramsey.com>
Date: Tue, 27 Jun 2023 11:01:12 +0200
Message-ID: <CAPyj-LDnkR+8Y3owNbtT1vgVtBJADE+Y1GTWMiZ8jDSxOZhUgA@mail.gmail.com>
To: PHP internals <internals@lists.php.net>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PHP-DEV] RFC1867 (multipart/form-data) PUT requests
From: tovilo.ilija@gmail.com (Ilija Tovilo)

Hi Ben, Hi Rowan

On Mon, Jun 26, 2023 at 8:55=E2=80=AFPM Ben Ramsey <ben@benramsey.com> wrot=
e:
>
> > On Jun 20, 2023, at 06:06, Rowan Tommins <rowan.collins@gmail.com> wrot=
e:
> >
> > On Tue, 20 Jun 2023 at 10:25, Ilija Tovilo <tovilo.ilija@gmail.com> wro=
te:
> >
> >> Introduce a new function (currently named populate_post_data()) to
> >> read the input stream and populate the $_POST and $_FILES
> >> superglobals.
> >
> > How about "request_form_populate_globals"?

The word "form" seems a bit out of place (even though it appears in
both multipart/form-data and application/x-www-form-urlencoded),
because this function is mainly targeted at PUT/PATCH requests for
REST APIs. Maybe request_body_populate_globals?

> Another option for the name: `populate_multipart_form_data()`.

I avoided the term "multipart" because the function technically also
works for application/x-www-form-urlencoded requests. It's less
necessary for the reasons outlined in my previous email, but it would
allow for consistent handling of such requests for all HTTP methods.

Some people on GitHub voiced that they would prefer an INI setting.
Therefore I will create an RFC accordingly.

Ilija