Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:120689
Message-ID: <15ba1311-3300-83ff-737b-58c4a90a2ad2@alec.pl>
Date: Tue, 27 Jun 2023 07:44:23 +0200
MIME-Version: 1.0
Content-Language: en-US
To: internals@lists.php.net
References: <CAH5C8xV2ph8GOTDVZjK968+_AKLrrgkoTNDZpK6oE71PXhrOPQ@mail.gmail.com>
 <6B872612-2F31-49E0-949C-CDF6FB2B9BE4@benramsey.com>
In-Reply-To: <6B872612-2F31-49E0-949C-CDF6FB2B9BE4@benramsey.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Subject: Re: [PHP-DEV] [RFC] [Vote] Deprecate functions with overloaded
 signatures
From: alec@alec.pl (Aleksander Machniak)

On 26.06.2023 20:22, Ben Ramsey wrote:

> I voted “no” on `IntlCalendar::set()` because it seems to me that `setDate()` and `setDateTime()` could share the same signature if `$hour`, `$minute`, and `$second` all default to zero, like this:
> 
>      public function setDate(int $year, int $month, int $dayOfMonth, int $hour = 0, int $minute = 0, int $second = 0): void {}
> 
> In the same way, with `IntlGregorianCalendar::__construct()`, `createFromDate()` and `createFromDateTime()` could be combined as:
> 
>      public static function createFromDate(int $year, int $month, int $dayOfMonth, int $hour = 0, int $minute = 0, int $second = 0): void {}

I also voted No on IntlCalendar and IntlGregorianCalendar changes. The 
proposed solution is not good enough.

IntlGregorianCalendar has already a static fromDateTime() method 
inherited from IntlCalendar, so a new method is not needed, imo.

Also, setTime() method already exists (not the best name), so addition 
of setDate() and setDateTime() will make it worse.

-- 
Aleksander Machniak
Kolab Groupware Developer        [https://kolab.org]
Roundcube Webmail Developer  [https://roundcube.net]
----------------------------------------------------
PGP: 19359DC1 # Blog: https://kolabian.wordpress.com