Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:120684
Content-Type: multipart/signed;
	boundary="Apple-Mail=_BCF147CA-77F6-46E1-9379-E68F6EC515E0";
	protocol="application/pgp-signature";
	micalg=pgp-sha256
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.600.7\))
Date: Mon, 26 Jun 2023 13:54:08 -0500
References: <CAPyj-LAabBCvrHUTgO4yoJATmvT0N2Kk7ZpwCb=Vo9aRbz7PtQ@mail.gmail.com>
 <CALKiJKoQudehGwZF9OrB=+rpmpz4My7WR3Fx34GUN2XZL9J1nQ@mail.gmail.com>
To: PHP internals <internals@lists.php.net>
In-Reply-To: <CALKiJKoQudehGwZF9OrB=+rpmpz4My7WR3Fx34GUN2XZL9J1nQ@mail.gmail.com>
Message-ID: <E7C8FDCD-4333-4D7A-BBB3-C365F9F1D8CA@benramsey.com>
Subject: Re: [PHP-DEV] RFC1867 (multipart/form-data) PUT requests
From: ben@benramsey.com (Ben Ramsey)

--Apple-Mail=_BCF147CA-77F6-46E1-9379-E68F6EC515E0
Content-Transfer-Encoding: 7bit
Content-Type: text/plain;
	charset=us-ascii

> On Jun 20, 2023, at 06:06, Rowan Tommins <rowan.collins@gmail.com> wrote:
> 
> On Tue, 20 Jun 2023 at 10:25, Ilija Tovilo <tovilo.ilija@gmail.com> wrote:
> 
>> Introduce a new function (currently named populate_post_data()) to
>> read the input stream and populate the $_POST and $_FILES
>> superglobals.
>> 
> 
> 
> My initial instinct was to discuss how this could be made more flexible in
> terms of input and output; but looking at how simple the implementation is,
> this seems like a really quick win, and anything else can be future scope.
> 
> To bikeshed the name a bit:
> 
> * We should probably avoid the word "post"; although it populates $_POST,
> that's really misnamed anyway, what we're really talking about is "form
> data"
> * Even if there isn't a current category prefix where it belongs, it should
> probably follow the "category_specific" naming scheme
> * We might in future add some related functions, such as returning the data
> rather than populating globals
> 
> How about "request_form_populate_globals"?


Another option for the name: `populate_multipart_form_data()`.

Cheers,
Ben




--Apple-Mail=_BCF147CA-77F6-46E1-9379-E68F6EC515E0
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
	filename=signature.asc
Content-Type: application/pgp-signature;
	name=signature.asc
Content-Description: Message signed with OpenPGP

-----BEGIN PGP SIGNATURE-----

iHUEAREIAB0WIQToXQMR3fpbrPOmEOewLZeYnIwHGwUCZJne0AAKCRCwLZeYnIwH
G6ToAQCRaPSZ6csWhCjy4jjOs47zxAuaj59Ek7C0gUOl3PQVMQD+MFn/Fo7i0NTE
g5pCn+vzdl9pDNIgtd6Nx59qL3CKvR8=
=zfqs
-----END PGP SIGNATURE-----

--Apple-Mail=_BCF147CA-77F6-46E1-9379-E68F6EC515E0--