Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:120683
Content-Type: multipart/signed;
	boundary="Apple-Mail=_2FF55C3E-C0AD-457B-94D2-95523B3B536F";
	protocol="application/pgp-signature";
	micalg=pgp-sha256
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.600.7\))
In-Reply-To: <CAH5C8xV2ph8GOTDVZjK968+_AKLrrgkoTNDZpK6oE71PXhrOPQ@mail.gmail.com>
Date: Mon, 26 Jun 2023 13:22:52 -0500
Cc: PHP Internals List <internals@lists.php.net>
Message-ID: <6B872612-2F31-49E0-949C-CDF6FB2B9BE4@benramsey.com>
References: <CAH5C8xV2ph8GOTDVZjK968+_AKLrrgkoTNDZpK6oE71PXhrOPQ@mail.gmail.com>
To: =?utf-8?B?TcOhdMOpIEtvY3Npcw==?= <kocsismate90@gmail.com>
Subject: Re: [PHP-DEV] [RFC] [Vote] Deprecate functions with overloaded
 signatures
From: ben@benramsey.com (Ben Ramsey)

--Apple-Mail=_2FF55C3E-C0AD-457B-94D2-95523B3B536F
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
	charset=utf-8

> On Jun 26, 2023, at 08:36, M=C3=A1t=C3=A9 Kocsis =
<kocsismate90@gmail.com> wrote:
>=20
> Hi Everyone,
>=20
> As previously announced on the list, I have just started the vote =
about the
> "Deprecate functions with overloaded signatures".
>=20
> Link to the RFC:
> =
https://wiki.php.net/rfc/deprecate_functions_with_overloaded_signatures
> Link to the discussion thread: https://externals.io/message/120146
>=20
> The vote is open until 2023-07-10 16:00:00 UTC.
>=20
> Regard,
> M=C3=A1t=C3=A9


Clarifying my =E2=80=9Cno=E2=80=9D votes=E2=80=A6

I voted =E2=80=9Cno=E2=80=9D on `array_keys()` because I do not see =
these as two different function signatures. To me, the single signature =
should look like this:

    function array_keys(array $array, ?mixed $filter_value =3D null, =
bool $strict =3D false): array {}

I voted =E2=80=9Cno=E2=80=9D on `IntlCalendar::set()` because it seems =
to me that `setDate()` and `setDateTime()` could share the same =
signature if `$hour`, `$minute`, and `$second` all default to zero, like =
this:

    public function setDate(int $year, int $month, int $dayOfMonth, int =
$hour =3D 0, int $minute =3D 0, int $second =3D 0): void {}

In the same way, with `IntlGregorianCalendar::__construct()`, =
`createFromDate()` and `createFromDateTime()` could be combined as:

    public static function createFromDate(int $year, int $month, int =
$dayOfMonth, int $hour =3D 0, int $minute =3D 0, int $second =3D 0): =
void {}


Cheers,
Ben



--Apple-Mail=_2FF55C3E-C0AD-457B-94D2-95523B3B536F
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
	filename=signature.asc
Content-Type: application/pgp-signature;
	name=signature.asc
Content-Description: Message signed with OpenPGP

-----BEGIN PGP SIGNATURE-----

iHUEAREIAB0WIQToXQMR3fpbrPOmEOewLZeYnIwHGwUCZJnXfAAKCRCwLZeYnIwH
Gw6GAQCFWKr+JQghKPvETcq8CCrk/fsK3yEnCQccrvXL7OHLZgD6AnDa+7HByyVV
Q13ZAiCcGbU7VpF+u/369Q2aZVOGcjI=
=qt3a
-----END PGP SIGNATURE-----

--Apple-Mail=_2FF55C3E-C0AD-457B-94D2-95523B3B536F--