Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:120674 Return-Path: Delivered-To: mailing list internals@lists.php.net Received: (qmail 76308 invoked from network); 25 Jun 2023 12:00:24 -0000 Received: from unknown (HELO php-smtp4.php.net) (45.112.84.5) by pb1.pair.com with SMTP; 25 Jun 2023 12:00:24 -0000 Received: from php-smtp4.php.net (localhost [127.0.0.1]) by php-smtp4.php.net (Postfix) with ESMTP id 57626180339 for ; Sun, 25 Jun 2023 05:00:22 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on php-smtp4.php.net X-Spam-Level: X-Spam-Status: No, score=0.6 required=5.0 tests=BAYES_50,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,HTML_MESSAGE, RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.2 X-Spam-ASN: AS15169 209.85.128.0/17 X-Spam-Virus: No X-Envelope-From: Received: from mail-pg1-f174.google.com (mail-pg1-f174.google.com [209.85.215.174]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature ECDSA (P-256) server-digest SHA256) (No client certificate requested) by php-smtp4.php.net (Postfix) with ESMTPS for ; Sun, 25 Jun 2023 05:00:21 -0700 (PDT) Received: by mail-pg1-f174.google.com with SMTP id 41be03b00d2f7-5535efe37b7so1093279a12.3 for ; Sun, 25 Jun 2023 05:00:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1687694420; x=1690286420; h=to:subject:message-id:date:from:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=kJgqoIe5q+jkmSgFhyjHFxUKbdNc7Wxxxd37vFjKo2U=; b=oHqUkBZtwx8aHF5R+Fnup2MR6QBpAIZwcF3AqpIEcpj94shh1NvLccOWATVPtZT/3H MAhyaArezCQvbU5QVmHEmmHll5OQbZelNBrwl6lOf4R35QLEpXxekCZ4rw+w88t8JHed /RueQdRrCznY3uZ2q8nOmm6El4rYHud5/728Oodoapfl5SzSzpp6ZauSfKi6/Bywfu3d QKYaaCxOo9fmQevkYZgzbrwgcxIbY/odJhQ/UB3YV0tOQ6qeomlxAY6JFIiI/kcrDvHJ mg5oW3YmbqcOSrdCcMBYogg1OPSgvXfhsKXDpxxsBSg2ARBvezzLFiygGPtqnMJTzvxd uyhg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687694420; x=1690286420; h=to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=kJgqoIe5q+jkmSgFhyjHFxUKbdNc7Wxxxd37vFjKo2U=; b=TM75HC6EIt5vdIfw4Amjj5KTkgsMXkzzYij03SvWOH7shEyuPyWEtncK1W5QQovZFn yS6EQZzGL1Rrd9co9QqIFyrEBDQLdpZl019P1UFG8MWJEeUoAFNOxFo80T1oTf0i+LFD ltHysYuc5xrW8cvJcG8/KFZPRtD0zaCva57teMAwHy8MUcfVU46yjvUYcf8rnk+0wXQ9 SrxzzwfdDWOaTbYuMKciW1T66GG/ZkDulOkq47Ds9gXUy4ySQ4yvPrlc+w9WDACr39zX 8YV0lb9xtmV1Neq2TU059AoEdm3qWRFUVUKoDX4rcseqj3b6c7tfRVNf8bLfBvH7p9Vs KavA== X-Gm-Message-State: AC+VfDxZhcLUKWcMJ6VCJeZGAAc7FJt8DdMzSM7xCgTW6qjYGjICdWd1 4Q4v9lQ+gi7nwh5e3Hd55UmDF2rdBuYhVkyoJYSlOJm8 X-Google-Smtp-Source: ACHHUZ5L9eqNNxlq6CfOXW6zH4IuSxG/dWn2SFEn5PE72XfYV/r0Q/WaV1WOCvti9OZzDFPmKyMBB7u8/C3P/LW54Tc= X-Received: by 2002:a05:6a20:970a:b0:125:8f6f:339 with SMTP id hr10-20020a056a20970a00b001258f6f0339mr4185536pzc.38.1687694420224; Sun, 25 Jun 2023 05:00:20 -0700 (PDT) MIME-Version: 1.0 Date: Sun, 25 Jun 2023 14:00:09 +0200 Message-ID: To: internals@lists.php.net Content-Type: multipart/alternative; boundary="00000000000068302f05fef2faaf" Subject: Adding $before_needle argument to strrchr() From: hypemc@gmail.com (Berislav) --00000000000068302f05fef2faaf Content-Type: text/plain; charset="UTF-8" Hi internals, I was told to ask for your feedback regarding the following PR I've opened: https://github.com/php/php-src/pull/11430. The PR adds a $before_needle argument to strrchr() that allows returning part of the haystack before the occurrence of the needle. Similar functions such as strstr(), stristr() or its mb counterpart mb_strrchr() already have this option, strrchr() seems to be the only one without it. According to Jakub Zelenka, if no one objects, the PR can get merged. Best regards, Berislav --00000000000068302f05fef2faaf--