Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:120669
MIME-Version: 1.0
References: <CAH5C8xXtCVHaxwzmAW_eBxp_D6p7kww9svND=3AEeC9X6--YXg@mail.gmail.com>
 <eaaa805e-86b2-ce8c-5a24-c301260d16ac@php.net> <CAOWwgpn3PY=4DQ7s2PxjET7__fx09wYqQOJR76L2owa9PX9tFA@mail.gmail.com>
 <017db925-da75-8054-7a35-c65457cd03ae@php.net> <CAOWwgpniYotForXo_UCdkriOTo-jz0HhdydLLNo18bBt3HKJqA@mail.gmail.com>
 <22541969-c914-c7d2-e1c6-d3b9bf674236@php.net>
In-Reply-To: <22541969-c914-c7d2-e1c6-d3b9bf674236@php.net>
Date: Fri, 23 Jun 2023 21:50:29 +0200
Message-ID: <CAH5C8xWQoQHc=bV+Lr94Z4MN9sN1QvEmo2QDO7khF=xTC_YbfQ@mail.gmail.com>
To: Derick Rethans <derick@php.net>
Cc: Nicolas Grekas <nicolas.grekas+php@gmail.com>, 
	PHP Internals List <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="000000000000d61cd105fed1506f"
Subject: Re: [PHP-DEV] [RFC] [Discussion] Deprecate functions with overloaded signatures
From: kocsismate90@gmail.com (=?UTF-8?B?TcOhdMOpIEtvY3Npcw==?=)

--000000000000d61cd105fed1506f
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi Derick,

In any case, I don't mind this =E2=80=94 I'm actually going to suggest to c=
hange
> the constructor to:
>
> public function __construct(DateTimeInterface $start, DateInterval
> $interval, DateTimeInterface|int $end, int $options =3D 0) {}
>
> And then *only* add:
>
> public static function createFromISO8601String(string $specification, int
> $options =3D 0): static {}
>
> This solves the original problem of not being able to define the
> signatures in stubs, and also extracts the most problematic of methods
> into a factory method where it should always have belonged.
>

Thanks for your response, I've just updated the RFC accordingly. It solves
the main issue indeed, and we still have the possibility to
add a second factory method using the $recurrences parameter later if we
deem it useful at some point.

With all that said, I don't want to update the RFC anymore, so I plan to
start the vote on Monday.

Regards,
M=C3=A1t=C3=A9

--000000000000d61cd105fed1506f--