Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:120637
MIME-Version: 1.0
References: <CAH5C8xXtCVHaxwzmAW_eBxp_D6p7kww9svND=3AEeC9X6--YXg@mail.gmail.com>
 <648B28D5.1060506@adviesenzo.nl> <CAH5C8xV7gbobYEg_xACcnG2za9gNrd8HqvSatsCKBVWJzH2Q2g@mail.gmail.com>
 <64912128.1@adviesenzo.nl>
In-Reply-To: <64912128.1@adviesenzo.nl>
Date: Tue, 20 Jun 2023 10:02:35 +0200
Message-ID: <CAH5C8xVK-5OTnOUk0xRa1CsnLpbtmy3rh6xcyox8T5uB_8qC7g@mail.gmail.com>
To: Juliette Reinders Folmer <php-internals_nospam@adviesenzo.nl>
Cc: internals@lists.php.net
Content-Type: multipart/alternative; boundary="000000000000a03af005fe8b135a"
Subject: Re: [PHP-DEV] [RFC] [Discussion] Deprecate functions with overloaded signatures
From: kocsismate90@gmail.com (=?UTF-8?B?TcOhdMOpIEtvY3Npcw==?=)

--000000000000a03af005fe8b135a
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi Juliette,

Respectfully though, in my opinion selectively leaving out impact analysis
> without mentioning why they are missing in the RFC, reeks of trying to hi=
de
> information which could influence the vote.
> Maybe just mentioning why the impact analysis is missing in these cases i=
n
> the RFC could take that stench away ?
>

I respectfully disagree that it would affect the vote result, but I added
the clarification you suggested nevertheless. :) Doing so resulted in a
very nice side-effect: I noticed that the array_keys_search() function name
is slightly inconsistent/misleading, since what it really does is to filter
keys based on their *value* (thus the $filter_value param name). So I
renamed it to array_keys_filter() as well as came up with
a new suggested replacement which is compatible with at least PHP 4: using
the combination of array_keys() and array_filter() retains the original
behavior (example is added to the RFC). I know
that it's less than ideal performance-wise, but it works anyway (and not
all code is performance sensitive).

Thanks,
M=C3=A1t=C3=A9

--000000000000a03af005fe8b135a--