Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:120628
MIME-Version: 1.0
In-Reply-To: <CAEwRQKZhpn+ydGkMf9aFK7emOWQYxE7Q+keN439k_R0e+hNriQ@mail.gmail.com>
References: <CAEwRQKYbasnxH1ePjOVfJA1ruSHoG_hHjUoZdvzy3AbQS36KXQ@mail.gmail.com>
 <CAG9XoMTPZ_kQzFvd3cnBqKh6Qjg5y6ve-SefN1=Z+s9-wFcNpg@mail.gmail.com> <CAEwRQKZhpn+ydGkMf9aFK7emOWQYxE7Q+keN439k_R0e+hNriQ@mail.gmail.com>
Date: Tue, 20 Jun 2023 07:17:48 +1000
Message-ID: <CAKVXxD-pKXU9VkJT21DBpM4qp9_SbpW+WCLNP3E+v=Y=sCFgiw@mail.gmail.com>
To: Vinicius Dias <carlosv775@gmail.com>
Cc: "internals@lists.php.net" <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="0000000000000f15be05fe8211a7"
Subject: Re: [PHP-DEV] Possible RFC: PDOStatement::addBatch
From: mickmackusa@gmail.com (mickmackusa)

--0000000000000f15be05fe8211a7
Content-Type: text/plain; charset="UTF-8"

So if I'm not missing something, you want to add this new method to core to
accommodate situations where:

1. the dev is too inexperienced to implement a pre-existing library and
2. the incoming 2d payload is not packaged as a csv file (and therefore
cannot be directly imported as such) and
3. the application does not benefit from accessing the auto-incremented ids
generated by each insert and
4. the performance of the bulk insertions resolves a crippling bottleneck
in performance?

IMO, the total footprint of your implemented snippet isn't significantly
"sleeker/sexier" than using concatenation.  I don't see anything ugly or
unreadable about building two flat arrays, then using them to construct a
SQL string and feed the execute() method. https://phpize.online/s/iW

I am not an RFC voter, but I don't really see a compelling reason to add
this method to the language.

mickmackusa

--0000000000000f15be05fe8211a7--