Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:120581
MIME-Version: 1.0
References: <CAH5C8xXtCVHaxwzmAW_eBxp_D6p7kww9svND=3AEeC9X6--YXg@mail.gmail.com>
 <eaaa805e-86b2-ce8c-5a24-c301260d16ac@php.net> <CAOWwgpn3PY=4DQ7s2PxjET7__fx09wYqQOJR76L2owa9PX9tFA@mail.gmail.com>
 <017db925-da75-8054-7a35-c65457cd03ae@php.net>
In-Reply-To: <017db925-da75-8054-7a35-c65457cd03ae@php.net>
Reply-To: Levi Morrison <levi.morrison@datadoghq.com>
Date: Wed, 14 Jun 2023 21:29:32 -0600
Message-ID: <CAAKU0um4jdoTorACKEpbEvwY+MTZieMSGtmPr6oBS8-eobvsRg@mail.gmail.com>
To: Derick Rethans <derick@php.net>
Cc: Nicolas Grekas <nicolas.grekas+php@gmail.com>, 
	PHP Internals List <internals@lists.php.net>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PHP-DEV] [RFC] [Discussion] Deprecate functions with overloaded signatures
From: internals@lists.php.net ("Levi Morrison via internals")

On Wed, Jun 14, 2023 at 4:06=E2=80=AFAM Derick Rethans <derick@php.net> wro=
te:
>
> On Tue, 13 Jun 2023, Nicolas Grekas wrote:
>
> > > I'm going to nitpick on the newly suggested names and argument order =
for
> > > the
> > > DatePeriod factory methods =E2=80=94 althoughI do agree that they nee=
d to get
> > > created:
> > >
> > > createFromInterval(DateTimeInterface $start, DateInterval $interval,
> > > DateTimeInterface $end, int $options =3D 0)
> > > =E2=86=92 createWithRange(DateTimeInterface $begin, DateTimeInterface=
 $end,
> > > DateTimeInterface $int, int $options =3D 0)
> > >
> > > createFromRecurrences(DateTimeInterface $start, DateInterval $interva=
l,
> > > int $recurrences, int $options =3D 0)
> > > =E2=86=92 createWithRecurrences(DateInterval $begin, int $recurrences=
,
> > > DateInterval $interval, int $options =3D 0)
> > >
> > > We also should fix the argument names. Either $start/$finish, or
> > > $begin/$end. I
> > > prefer the latter.
> > >
> > > createFromIso8601(string $specification, int $options =3D 0)
> > > -> createFromISO8601String
> > >
> > > I am open to bike shedding about this :-)
> > >
> >
> > On my side, I'd very much prefer keeping the constructor of DatePeriod =
and
> > thus making it non-overloaded with this signature:
> >
> > public function __construct(DateTimeInterface $start, DateInterval
> > $interval, DateTimeInterface|int $end, int $options =3D 0) {}
>
> That still has an overloaded third argument =E2=80=94 DateTimeInterface|i=
nt.

This specific case is not that problematic. Since things need
untangling anyway, I would feel free to improve it if something is
done, but it's not much of a problem.

The problem is when there's a wildly different signature, or if args
change the return type structure, etc. So in this case, the problem is
really:

    public function __construct(string $isostr, int $options =3D 0) {}

Which can't really be unified with the others very well.