Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:120562
MIME-Version: 1.0
References: <CAH5C8xXtCVHaxwzmAW_eBxp_D6p7kww9svND=3AEeC9X6--YXg@mail.gmail.com>
 <eaaa805e-86b2-ce8c-5a24-c301260d16ac@php.net> <CAH5C8xUrNktmO=t1-357uE0UAZHe0O2zYdAxwE3a0Oo-MK7R=Q@mail.gmail.com>
 <CAH5C8xXjMP+D5szYCZdWqe2pdQTPOMbuFEtJGZeoeTYBcJFOrw@mail.gmail.com>
 <108411AD-DBC4-4436-8190-7569B7A0805F@gmail.com> <CAH5C8xXY3-YjbO6Dq20hRmLUETA3FEpx+rk4+9J3LwO10R6ojA@mail.gmail.com>
 <CAH5C8xW2eXsC5tY5zkZo9TE2QsvvDjdaLzjjZiGKHSJZq6qFJw@mail.gmail.com>
 <CAH5C8xVZ3acxQj0J9aAoi=JuCTS_YyMftLPmpj2xKYaN4eFQVQ@mail.gmail.com> <CALKiJKqjZD6jGcO7HzevkbTKOHc9x5MrL56wUiR8h_-HDqvwCw@mail.gmail.com>
In-Reply-To: <CALKiJKqjZD6jGcO7HzevkbTKOHc9x5MrL56wUiR8h_-HDqvwCw@mail.gmail.com>
Date: Tue, 13 Jun 2023 16:49:53 +0200
Message-ID: <CAH5C8xWv28k0c0Vkack3SGvGa9EFLmrZkVw=UmSPV1HN-jeFCw@mail.gmail.com>
To: Rowan Tommins <rowan.collins@gmail.com>
Cc: PHP Internals List <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="0000000000005fd1f405fe03f34a"
Subject: Re: [PHP-DEV] [RFC] [Discussion] Deprecate functions with overloaded signatures
From: kocsismate90@gmail.com (=?UTF-8?B?TcOhdMOpIEtvY3Npcw==?=)

--0000000000005fd1f405fe03f34a
Content-Type: text/plain; charset="UTF-8"

>
> It looks like the current preferred signature was only introduced in PHP
> 8.2. Previously, the signatures were dba_fetch($key, $handle) and
> dba_fetch($key, $skip, $handle) - it effectively had a non-final optional
> parameter.
>

Yes, that's the case! Thanks for reminding me again, I clarified in the RFC
that PHP 8.2 is the first version which supports the preferred signature.


> Whether that makes it too early to deprecate the older 3-parameter form,
> I'm not sure. As you say, it's probably pretty rare, particularly because
> according to the docs that parameter is ignored for most file formats the
> function supports anyway.
>

Normally, I wouldn't do this, but I'm certain that deprecating this
signature won't cause a big havoc in the PHP ecosystem, so that's the only
reason I went ahead.

>

--0000000000005fd1f405fe03f34a--