Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:120558
Message-ID: <08fb4710-618a-6202-acc5-5b898dc36e41@bastelstu.be>
Date: Mon, 12 Jun 2023 17:24:47 +0200
MIME-Version: 1.0
To: internals@lists.php.net
References: <e58dde83-654d-b0ad-de77-d0450a56ef75@bastelstu.be>
Content-Language: en-US
In-Reply-To: <e58dde83-654d-b0ad-de77-d0450a56ef75@bastelstu.be>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Subject: Re: [PHP-DEV] RFC [Discussion]: Marking overridden methods
 (#[\Override])
From: tim@bastelstu.be (=?UTF-8?Q?Tim_D=c3=bcsterhus?=)

Hi

On 5/11/23 18:37, Tim Düsterhus wrote:
> I'm now opening discussion for the RFC "Marking overridden methods
> (#[\Override])":
> 
> ----
> 
> RFC: Marking overridden methods (#[\Override])
> https://wiki.php.net/rfc/marking_overriden_methods
> 
> Proof of concept implementation is in:
> 
> https://github.com/php/php-src/pull/9836

Discussion has died down, unfortunately without (much) commentary with 
regard to Claude's and Sara's suggestions. However I believe that the 
proposal is in a state where is brings a real benefit and where it is 
also extensible in the future, e.g. to include Claude's "No implicit 
override" suggestion. I have included it in the "Future Scope" section. 
Sara's first proposal to make it a LSP check bypass I have added to the 
"rejected features" section, as argued in my previous response to it.

I've also added references for Swift and Kotlin, as these languages 
where mentioned in PHP Core Roundup #13 by The PHP Foundation.

I plan to start the vote later this week, possibly on Wednesday.

Best regards
Tim Düsterhus