Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:120557
MIME-Version: 1.0
References: <CAH5C8xXtCVHaxwzmAW_eBxp_D6p7kww9svND=3AEeC9X6--YXg@mail.gmail.com>
 <eaaa805e-86b2-ce8c-5a24-c301260d16ac@php.net> <CAH5C8xUrNktmO=t1-357uE0UAZHe0O2zYdAxwE3a0Oo-MK7R=Q@mail.gmail.com>
 <CAH5C8xXjMP+D5szYCZdWqe2pdQTPOMbuFEtJGZeoeTYBcJFOrw@mail.gmail.com>
 <108411AD-DBC4-4436-8190-7569B7A0805F@gmail.com> <CAH5C8xXY3-YjbO6Dq20hRmLUETA3FEpx+rk4+9J3LwO10R6ojA@mail.gmail.com>
 <CAH5C8xW2eXsC5tY5zkZo9TE2QsvvDjdaLzjjZiGKHSJZq6qFJw@mail.gmail.com> <CAH5C8xVZ3acxQj0J9aAoi=JuCTS_YyMftLPmpj2xKYaN4eFQVQ@mail.gmail.com>
In-Reply-To: <CAH5C8xVZ3acxQj0J9aAoi=JuCTS_YyMftLPmpj2xKYaN4eFQVQ@mail.gmail.com>
Date: Mon, 12 Jun 2023 16:07:13 +0100
Message-ID: <CALKiJKqjZD6jGcO7HzevkbTKOHc9x5MrL56wUiR8h_-HDqvwCw@mail.gmail.com>
To: =?UTF-8?B?TcOhdMOpIEtvY3Npcw==?= <kocsismate90@gmail.com>
Cc: PHP Internals List <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="00000000000092f88805fdf0139f"
Subject: Re: [PHP-DEV] [RFC] [Discussion] Deprecate functions with overloaded signatures
From: rowan.collins@gmail.com (Rowan Tommins)

--00000000000092f88805fdf0139f
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Sat, 10 Jun 2023 at 08:40, M=C3=A1t=C3=A9 Kocsis <kocsismate90@gmail.com=
> wrote:

> In the meanwhile, I noticed yet another overloaded function (dba_fetch())
> and I included it into the proposal. In my opinion, it's a no-brainer
> to deprecate due to its low adoption rate and very odd behavior - to say =
at
> least.
>


It looks like the current preferred signature was only introduced in PHP
8.2. Previously, the signatures were dba_fetch($key, $handle) and
dba_fetch($key, $skip, $handle) - it effectively had a non-final optional
parameter.

Whether that makes it too early to deprecate the older 3-parameter form,
I'm not sure. As you say, it's probably pretty rare, particularly because
according to the docs that parameter is ignored for most file formats the
function supports anyway.

Regards,
--=20
Rowan Tommins
[IMSoP]

--00000000000092f88805fdf0139f--