Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:120556
Date: Sun, 11 Jun 2023 22:15:29 +0100
To: =?ISO-8859-1?Q?M=E1t=E9_Kocsis?= <kocsismate90@gmail.com>,
 internals@lists.php.net
User-Agent: K-9 Mail for Android
In-Reply-To: <CAH5C8xW2eXsC5tY5zkZo9TE2QsvvDjdaLzjjZiGKHSJZq6qFJw@mail.gmail.com>
References: <CAH5C8xXtCVHaxwzmAW_eBxp_D6p7kww9svND=3AEeC9X6--YXg@mail.gmail.com> <eaaa805e-86b2-ce8c-5a24-c301260d16ac@php.net> <CAH5C8xUrNktmO=t1-357uE0UAZHe0O2zYdAxwE3a0Oo-MK7R=Q@mail.gmail.com> <CAH5C8xXjMP+D5szYCZdWqe2pdQTPOMbuFEtJGZeoeTYBcJFOrw@mail.gmail.com> <108411AD-DBC4-4436-8190-7569B7A0805F@gmail.com> <CAH5C8xXY3-YjbO6Dq20hRmLUETA3FEpx+rk4+9J3LwO10R6ojA@mail.gmail.com> <CAH5C8xW2eXsC5tY5zkZo9TE2QsvvDjdaLzjjZiGKHSJZq6qFJw@mail.gmail.com>
Message-ID: <D25C28C4-271D-456D-99A5-DA66971FCD00@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain;
 charset=utf-8
Content-Transfer-Encoding: quoted-printable
Subject: =?US-ASCII?Q?Re=3A_Fwd=3A_=5BPHP-DEV=5D_=5BRFC=5D_=5BDiscussion=5D_Depr?= =?US-ASCII?Q?ecate_functions_with_overloaded_signatures?=
From: rowan.collins@gmail.com (Rowan Tommins)

On 10 June 2023 08:31:24 BST, "M=C3=A1t=C3=A9 Kocsis" <kocsismate90@gmail=
=2Ecom> wrote:
>Hmm, that's also a very good idea, and I support this=2E However, I'm
>hesitant to deprecate the 2 parameter version of session_set_save_handler=
()
>just yet,
>since doing so would mean that everyone using sessions has to use a new
>function=2E=2E=2E Instead, I opted for aliasing it to the new
>session_set_handler() function (I'm not fond
>of the "_object" postfix, because I regard it unnecessary as it operates =
on
>SessionHandlerInterface instances)=2E And we could maybe deprecate
>session_set_save_handler()
>altogether in a few years=2E


Hm, I think we're not quite on the same page here=2E In my mind, the only =
reason to change anything about this function is that we can't properly ove=
rload a function based on its argument types=2E There's nothing particularl=
y "primary" or "better" about either of the two signatures, it's just hard =
to document and use named parameters while they're both part of one functio=
n=2E

My suggestion was very explicitly that everyone using sessions should have=
 to change their code, to a name that explicitly mentions the parameter typ=
e in its name (because that's the difference between the two)=2E As I said,=
 I think it's much simpler to communicate "this function is deprecated, cho=
ose the appropriate from these two names", rather than "this function is de=
precated in one format, but not the other, and if you are using the depreca=
ted format, you can use this instead"=2E

Both the "_object" suffix (or some equivalent) and deprecating the origina=
l regardless of signature are inherent in my suggestion=2E You seem to have=
 interpreted it as something else, and I'm not entirely sure what you're ac=
tually proposing - how does an alias fit in to something that's about split=
ting a function into two?

Regards,

--=20
Rowan Tommins
[IMSoP]