Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:12055 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 60073 invoked by uid 1010); 10 Aug 2004 08:01:28 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 59994 invoked from network); 10 Aug 2004 08:01:27 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by pb1.pair.com with SMTP; 10 Aug 2004 08:01:27 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.12.10/8.12.10) with ESMTP id i7A81Re1004249 for ; Tue, 10 Aug 2004 04:01:27 -0400 Received: from radish.cambridge.redhat.com (radish.cambridge.redhat.com [172.16.18.90]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id i7A81Qa09146 for ; Tue, 10 Aug 2004 04:01:26 -0400 Received: from radish.cambridge.redhat.com (localhost.localdomain [127.0.0.1]) by radish.cambridge.redhat.com (8.12.10/8.12.7) with ESMTP id i7A81PHP007936 for ; Tue, 10 Aug 2004 09:01:25 +0100 Received: (from jorton@localhost) by radish.cambridge.redhat.com (8.12.10/8.12.10/Submit) id i7A81Pl3007935 for internals@lists.php.net; Tue, 10 Aug 2004 09:01:25 +0100 Date: Tue, 10 Aug 2004 09:01:24 +0100 To: internals@lists.php.net Message-ID: <20040810080124.GA7896@redhat.com> Mail-Followup-To: internals@lists.php.net References: <20040723211815.GB15309@redhat.com> <20040807160217.GA15321@redhat.com> <200408090946.21859.edink@emini.dk> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <200408090946.21859.edink@emini.dk> User-Agent: Mutt/1.4.1i Subject: Re: [PHP-DEV] [PATCH] fix symbol namespace pollution from bundled libgd From: jorton@redhat.com (Joe Orton) On Mon, Aug 09, 2004 at 09:46:21AM +0200, Edin Kadribasic wrote: > On Monday 09 August 2004 09:00, Derick Rethans wrote: > > On Sat, 7 Aug 2004, Joe Orton wrote: > > > That would mean adding exactly the reverse set of #defines to allow the > > > the GD extension to be built against an external copy of libgd (which of > > > course won't use the phpgd_* symbols). > > > > > > Given that a complete set of #defines is needed anyway, doing it without > > > modifying libgd makes more sense since it's then easier to track the > > > upstream libgd sources. > > > > Right ;-) Can you please update your patch with the new symbols then? > > I'll commit it then later (or just ask for a CVS account!) > > I'm -1 on this patch. The problem is has existed for mysql lib for ages and > for all other libraries used by PHP. For all other libraries *which are bundled with PHP*, not just *used* by PHP. Why are the php_compat.h #defines acceptable to fix this issue for PCRE and expat, but not for libgd? > A note in the documentation stating that > if you want to use GD from PHP and another Apache module you need to compile > PHP with the external library should be sufficient. This would be a reasonable argument if the libgd bundled with PHP was exactly the same as the upstream libgd, but that's not the case, the libgd bundled with PHP is extensively modified. joe