Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:120514
MIME-Version: 1.0
References: <CAPTD5yHUdoqZ8AA5LzkHY784W2L3mHj2yrazWrGzha7xZ101NQ@mail.gmail.com>
 <25c841b2-d179-ba8d-d452-d0cdd28363d8@php.net> <CAJmy8YHNFv53S6OnA3_Fd3uN+_y_C1rHw7SOnwpaaQ4CnsMjMQ@mail.gmail.com>
In-Reply-To: <CAJmy8YHNFv53S6OnA3_Fd3uN+_y_C1rHw7SOnwpaaQ4CnsMjMQ@mail.gmail.com>
Date: Fri, 2 Jun 2023 20:33:52 +0200
Message-ID: <CAJmy8YEwuRpYZ1Fnov7EE41=J9zLLhh4J75-_JWqxhMPkJ1YKQ@mail.gmail.com>
Cc: PHP internals <internals@lists.php.net>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PHP-DEV] Deprecation of the formats DATE_ISO8601 and DATE_RFC7231
From: divinity76@gmail.com (Hans Henrik Bergan)

DATE_ISO8601 doesn't have to be removed anytime soon, but no new code
should be written using that constant, thus an E_DEPRECATED is
warranted.

Is anyone really arguing against that statement?

On Tue, 30 May 2023 at 18:26, Hans Henrik Bergan <divinity76@gmail.com> wro=
te:
>
> >In my opinion, deprecating this does not do anything besides annoying
> users.
>
> In my opinion, since it isn't, and likely never was, a legal ISO8601
> string, it's a no-brainer that it should be deprecated. (it's at least
> been illegal since iso8601:2004 released in 2004)
>
> On Fri, 26 May 2023 at 12:17, Derick Rethans <derick@php.net> wrote:
> >
> > On Fri, 19 May 2023, Jorg Sowa wrote:
> >
> > > I would like to propose the deprecation of the constants DATE_ISO8601=
,
> > > DateTimeInterface::ISO8601 and DateTimeInterface::RFC7231, DATE_RFC72=
31.
> >
> > =E2=80=A6
> >
> > > In my opinion the question is not whether this constant should be
> > > deprecated, but when. I know that the problem was discussed in the pa=
st,
> > > but I hope enough time has passed already to touch this topic again
> > > although of the BC nature. [6] <https://externals.io/message/113657#1=
14885>
> > > [7]
> >
> > In my opinion, deprecating this does not do anything besides annoying
> > users.
> >
> > > <https://www.reddit.com/r/PHP/comments/hnd438/why_isnt_date_iso8601_d=
eprecated/>
> > > Arguments for deprecating DATE_RFC7231:
> > > - error prone nature, the format never really supported timezone. I'm=
 not
> > > sure how it appeared in the code, but tests clearly lack cases for th=
is
> > > format. I'm not sure if it was missed on purpose, but with tests it w=
ould
> > > be obvious that the format shouldn't ever appear in the core. [8]
> > > <https://www.php.net/manual/en/class.datetimeinterface.php> [9]
> > > <https://github.com/php/doc-en/pull/2296>
> >
> > This should instead be fixed of being deprecated. It is a recent
> > addition after all.
> >
> > cheers,
> > Derick
> >
> > --
> > PHP Internals - PHP Runtime Development Mailing List
> > To unsubscribe, visit: https://www.php.net/unsub.php