Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:120508
MIME-Version: 1.0
References: <97308c1d-e9f0-e28d-78ba-11da2a136ee6@fide.pl> <6c66ad82-7616-4b22-8961-494b557a3def@app.fastmail.com>
In-Reply-To: <6c66ad82-7616-4b22-8961-494b557a3def@app.fastmail.com>
Date: Fri, 2 Jun 2023 03:24:20 +0200
Message-ID: <CAJmy8YEZHRm0OEZYt=pzfwn2cO_X1sTvHVnYLri34XdmKUxxug@mail.gmail.com>
To: Casper Langemeijer <langemeijer@php.net>
Cc: internals@lists.php.net
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PHP-DEV] Proposal: addition of array_find() and array_find_key() functions
From: divinity76@gmail.com (Hans Henrik Bergan)

sounds like array_find could be implemented by just adding a new flag
for array_filter's $mode:
ARRAY_FILTER_STOP_ON_FIRST_MATCH
or some such?

On Fri, 2 Jun 2023 at 02:15, Casper Langemeijer <langemeijer@php.net> wrote=
:
>
> On Thu, Jun 1, 2023, at 18:02, Janusz Szczypka wrote:
> > array_find(): This function would allow developers to find the first el=
ement in
> > an array that satisfies a specific condition. The condition would be de=
fined by a callback function.
>
> This would actually be an alternative to a simple foreach() with an if() =
and a break. As your example implementation makes clear.
>
> array_find() and array_find_key() would still do the same internally, but=
 add a function call adding the overhead of pushing parameters to stack, sw=
itching the scope, passing return value back switch scope and pop from the =
callstack again. If parameters or return value are typed this adds even mor=
e overhead.
>
> I don't think there is any optimisation possible when this is done in C.
>
> To the proposer it probably feels that this is an array function currentl=
y missing, but instead it's probably better not to have array_find() becaus=
e people might actually use it for larger datasets.
>
> Although I acknowledge that it will reduce the number of lines of PHP cod=
e it doesn't actually reduce the mental capacity to read and maintain code.=
 I find the simple elemental building blocks of loops, conditionals and exp=
ressions easier and more expressive. In my experience this is especially so=
 for less experienced developers.
>
> Then there is a problem of naming. array_search() and array_find(). To a =
new developer, how would they know which is which?
>
> Also there is the missing array_find_value_and_key() method. Because why =
should we be limited to either matching the key OR the value?
>
> Greetings, Casper
>