Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:120495
Message-ID: <AF07E02E-2F3B-4D74-91FA-943DBDDD413F@gmail.com>
Content-Type: multipart/alternative;
	boundary="Apple-Mail=_AFE1DAEF-6790-41BC-9E4C-98E4F8163A5F"
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.600.7\))
Date: Thu, 1 Jun 2023 01:02:31 +0200
In-Reply-To: <1fcd4791-38a6-4467-8033-b0686f505af7@app.fastmail.com>
Cc: php internals <internals@lists.php.net>
To: Larry Garfield <larry@garfieldtech.com>
References: <289E585B-EF8B-4B17-89BE-BE8295FD9FE1@gmail.com>
 <831B6DDD-B017-482A-9288-E31D44FC0298@gmail.com>
 <155203BE-9037-4F24-9EBC-A46EAE2ACBF5@gmail.com>
 <1fcd4791-38a6-4467-8033-b0686f505af7@app.fastmail.com>
Subject: Re: [PHP-DEV] [RFC] [Discussion] Add new function `array_group`
From: buritomath@gmail.com (Boro Sitnikovski)

--Apple-Mail=_AFE1DAEF-6790-41BC-9E4C-98E4F8163A5F
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
	charset=us-ascii



> On 1.6.2023, at 00:59, Larry Garfield <larry@garfieldtech.com> wrote:
>=20
> On Wed, May 31, 2023, at 10:47 PM, Boro Sitnikovski wrote:
>=20
>> 1. The grouping that JavaScript/.NET/Lodash/Scala/etc. do (this =
should=20
>> be the default of `array_group`)
>> 2. The grouping that Haskell does, the one I proposed earlier (this =
can=20
>> be altered in a flag within `array_group`)
>>=20
>> Based on this, I'd like to adjust my initial proposal, where we would=20=

>> have the following function: `function array_group(array $array,=20
>> callable $callback, bool $consecutive_pairs =3D false): array {}`
>>=20
>> If the argument `consecutive_pairs` is false, it will use the=20
>> function's return value to do the grouping ($callback accepting =
single=20
>> element in this case)
>> Otherwise, it will use the function's boolean return value to check =
if=20
>> two consecutive elements need to be grouped ($callback accepting two=20=

>> elements in this case)
>>=20
>> (This approach seems to be consistent with `array_filter` in the =
sense=20
>> the callback accepts one or two arguments)
>>=20
>> With a few example usages:
>>=20
>> ```
>> var_dump( array_group($arr1, function( $x ) {
>> return (string) strlen( $x );
>> } ) );
>> // Producing ['3' =3D> ['one', 'two'], '5' =3D> ['three']]
>> ```
>>=20
>> Another one:
>>=20
>> ```
>> $arr =3D [-1,2,-3,-4,2,1,2,-3,1,1,2];
>>=20
>> $groups =3D array_group( $arr, function( $p1, $p2 ) {
>>  return ($p1 > 0) =3D=3D ($p2 > 0);
>> } );
>> // Producing [[-1],[2],[-3,-4],[2,1,2],[-3],[1,1,2]]
>> ```
>=20
> This sounds like two separate functions in a trenchcoat.  It should be =
two separate functions.
>=20
>> I believe this proposal captures many use cases, beyond the examples =
we=20
>> discussed. Curious about any other thoughts.
>>=20
>> I'm also attaching a PoC patch that implements this.
>>=20
>> Attachments:
>> * array_group.patch
>=20
> Side note: I don't think anyone reads patches sent to the list.  I =
didn't even realize it allowed attachments. :-)  If you want someone to =
review code, a GitHub PR is the way to go.
>=20
> You can also include benchmarks there.  =46rom experience, if you =
don't have a compelling reason why this *needs* to be in C rather than =
PHP (which in this case boils down to performance exclusively), you're =
not going to be able to convince people to add another random utility =
function.  That's just the reality these days.
>=20
> --Larry Garfield
>=20
> --=20
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: https://www.php.net/unsub.php

Thank you for your thoughts. We can definitely separate them in two =
functions. Also thanks on the note for the patches - will keep it in =
mind :)

Good point on the benchmarks, I will keep those in mind.

Beyond performance, I think this has to do with developer experience =
pretty much, too. Almost all mainstream languages have a built-in =
grouping function, and in my honest opinion, it's time PHP has one too =
:) I think we can all agree grouping is a very common/basic =
functionality that we all meet with regularly.=

--Apple-Mail=_AFE1DAEF-6790-41BC-9E4C-98E4F8163A5F--