Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:120485
MIME-Version: 1.0
References: <289E585B-EF8B-4B17-89BE-BE8295FD9FE1@gmail.com> <12bede25-36ad-037d-8802-6348da7a2e3d@alec.pl>
In-Reply-To: <12bede25-36ad-037d-8802-6348da7a2e3d@alec.pl>
Date: Wed, 31 May 2023 11:49:27 +0300
Message-ID: <CAF-mU4xMskp2cHtjZM3FB74EY6b1yvPshjQbO-PtQkuuD08=-g@mail.gmail.com>
To: Aleksander Machniak <alec@alec.pl>
Cc: internals@lists.php.net
Content-Type: text/plain; charset="UTF-8"
Subject: Re: [PHP-DEV] [RFC] [Discussion] Add new function `array_group`
From: rokas.sleinius@gmail.com (=?UTF-8?Q?Rokas_=C5=A0leinius?=)

On Wed, 31 May 2023 at 10:30, Aleksander Machniak <alec@alec.pl> wrote:
>
> On 30.05.2023 13:34, Boro Sitnikovski wrote:
> > I propose introducing a function to PHP core named `array_group`. This
> > function takes an array and a function and returns an array that
> > contains arrays - groups of consecutive elements. This is very similar
> > to Haskell's `groupBy` function
> > <https://hackage.haskell.org/package/groupBy-0.1.0.0/docs/Data-List-GroupBy.html>.
>
>
> Sorry, I'm sick right now and have no clue, but how does it relate to
> https://wiki.php.net/rfc/array_column_results_grouping
>
> --
> Aleksander Machniak
> Kolab Groupware Developer        [https://kolab.org]
> Roundcube Webmail Developer  [https://roundcube.net]
> ----------------------------------------------------
> PGP: 19359DC1 # Blog: https://kolabian.wordpress.com
>
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: https://www.php.net/unsub.php
>

Okay, I will just share my decade-plus-old take on this problem for
anyone interested.

I find defining the desired array grouping rules is self-explanatory -
and can get arbitrarily complex when required - in this format:
`columnA=>*`.

The format can get as complex as `columnA[columnB][]=>columnC,columnA`
- and more - and I bet you can decipher what you get from that without
much difficulty nor documentation. It's also quite simple to compose
your own.

Here's the whole source code for the PHP function along with test coverage:

https://github.com/laravel/framework/discussions/45638

Cheers