Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:120475
Message-ID: <92AF3C3F-3B08-4842-986A-3C7AC9EB7A89@gmail.com>
Content-Type: multipart/alternative;
	boundary="Apple-Mail=_0E9D7040-7577-49A1-900D-FE3D1E7C116D"
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.600.7\))
Date: Tue, 30 May 2023 19:42:14 +0200
In-Reply-To: <e5283ad4-b5a8-404b-877d-9baec715cf7b@app.fastmail.com>
Cc: php internals <internals@lists.php.net>
To: Larry Garfield <larry@garfieldtech.com>
References: <289E585B-EF8B-4B17-89BE-BE8295FD9FE1@gmail.com>
 <CAB-BujYyz4vFAmi+OKi0rjqViE02eUjDpkkYyAMRCf10t8mNXA@mail.gmail.com>
 <4CA1668E-A342-452E-A994-5839C377CB27@gmail.com>
 <CAB-BujY2f3tM5CwRVAuVj962iC_9K=1X1A0at2QVdORxQDqx3A@mail.gmail.com>
 <B35AAF0F-B899-4771-AAFD-1109BE7A9B7D@gmail.com>
 <e5283ad4-b5a8-404b-877d-9baec715cf7b@app.fastmail.com>
Subject: Re: [PHP-DEV] [RFC] [Discussion] Add new function `array_group`
From: buritomath@gmail.com (Boro Sitnikovski)

--Apple-Mail=_0E9D7040-7577-49A1-900D-FE3D1E7C116D
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
	charset=us-ascii



> On 30.5.2023, at 19:21, Larry Garfield <larry@garfieldtech.com> wrote:
>=20
> On Tue, May 30, 2023, at 4:27 PM, Boro Sitnikovski wrote:
>> Hi,
>>=20
>> Thank you for your thoughts.
>>=20
>>> I would say the more common desired behavior is the one in your =
first
>>> example. And even for that we don't have a native function.
>>=20
>> This Google search might give more insight into the number of=20
>> discussions about a grouping functionality:=20
>> =
https://www.google.com/search?q=3Dphp+group+elements+site:stackoverflow.co=
m
>>=20
>>> Your behavior can be implemented in userland like so:
>>> https://3v4l.org/epvHm
>>=20
>> Correct, but then again, we can also implement=20
>> `array_map`/`array_filter`/etc. in userland :)
>>=20
>>> I think you need to make a case as to why the behavior you describe
>>> justifies a native function.
>>=20
>> Similar to my previous answer, but also in general - ease of access =
and=20
>> also performance.
>=20
> Do you have benchmarks showing that implementing it in C would be =
notably faster?  That would help the case that it should be written in =
C.
>=20
> Also, please do not top-post.
>=20
> --Larry Garfield
>=20
> --=20
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: https://www.php.net/unsub.php

Sorry for the top-posting, my bad.

I ran some performance benchmarks and the improvement is about 25% - =
some details on the following gist: =
https://gist.github.com/bor0/3fa539263335fa415faa67606a469f2e?permalink_co=
mment_id=3D4584327#gistcomment-4584327=

--Apple-Mail=_0E9D7040-7577-49A1-900D-FE3D1E7C116D--