Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:120473
Feedback-ID: i8414410d:Fastmail
User-Agent: Cyrus-JMAP/3.9.0-alpha0-447-ge2460e13b3-fm-20230525.001-ge2460e13
Mime-Version: 1.0
Message-ID: <e5283ad4-b5a8-404b-877d-9baec715cf7b@app.fastmail.com>
In-Reply-To: <B35AAF0F-B899-4771-AAFD-1109BE7A9B7D@gmail.com>
References: <289E585B-EF8B-4B17-89BE-BE8295FD9FE1@gmail.com>
 <CAB-BujYyz4vFAmi+OKi0rjqViE02eUjDpkkYyAMRCf10t8mNXA@mail.gmail.com>
 <4CA1668E-A342-452E-A994-5839C377CB27@gmail.com>
 <CAB-BujY2f3tM5CwRVAuVj962iC_9K=1X1A0at2QVdORxQDqx3A@mail.gmail.com>
 <B35AAF0F-B899-4771-AAFD-1109BE7A9B7D@gmail.com>
Date: Tue, 30 May 2023 17:21:42 +0000
To: "php internals" <internals@lists.php.net>
Content-Type: text/plain
Subject: Re: [PHP-DEV] [RFC] [Discussion] Add new function `array_group`
From: larry@garfieldtech.com ("Larry Garfield")

On Tue, May 30, 2023, at 4:27 PM, Boro Sitnikovski wrote:
> Hi,
>
> Thank you for your thoughts.
>
>> I would say the more common desired behavior is the one in your first
>> example. And even for that we don't have a native function.
>
> This Google search might give more insight into the number of 
> discussions about a grouping functionality: 
> https://www.google.com/search?q=php+group+elements+site:stackoverflow.com
>
>> Your behavior can be implemented in userland like so:
>> https://3v4l.org/epvHm
>
> Correct, but then again, we can also implement 
> `array_map`/`array_filter`/etc. in userland :)
>
>> I think you need to make a case as to why the behavior you describe
>> justifies a native function.
>
> Similar to my previous answer, but also in general - ease of access and 
> also performance.

Do you have benchmarks showing that implementing it in C would be notably faster?  That would help the case that it should be written in C.

Also, please do not top-post.

--Larry Garfield