Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:120469
MIME-Version: 1.0
References: <CAB-BujYFQL6swvTXz7vBK7x_b8z3W1Sry=1pFo9a8CGk3PO2Yg@mail.gmail.com>
 <c62ec1b5-eab8-4d3a-af9c-6eda3a9272f5@app.fastmail.com>
In-Reply-To: <c62ec1b5-eab8-4d3a-af9c-6eda3a9272f5@app.fastmail.com>
Date: Tue, 30 May 2023 18:54:30 +0200
Message-ID: <CAB-BujYJ=9Ag0HwVhFfc0vi1dprBvDVMKdyXbwFLUOSpmp7Cyw@mail.gmail.com>
To: Larry Garfield <larry@garfieldtech.com>
Cc: php internals <internals@lists.php.net>
Content-Type: text/plain; charset="UTF-8"
Subject: Re: [PHP-DEV] Let ReflectionMethod keep track of original class
From: andreas@dqxtech.net (Andreas Hennings)

On Tue, 30 May 2023 at 18:48, Larry Garfield <larry@garfieldtech.com> wrote:
>
>
>
> --
>   Larry Garfield
>   larry@garfieldtech.com
>
> On Tue, May 30, 2023, at 2:42 AM, Andreas Hennings wrote:
> > Hello list,
> > this proposal will be useful in combination with "Declaration-aware attributes"
> >
> >
> > Problem
> > ========
> > Currently, ReflectionMethod is not aware of the original class, if the
> > method is declared in a parent class.
> > Methods that are called during a discovery algorithm that need to
> > process a method with its original class typically need two
> > parameters:
> >
> > function processMethod(\ReflectionClass $class, \ReflectionMethod $method) {..}
> >
> >
> > Proposal
> > ========
> > Let a ReflectionMethod object keep track of the original class.
> > Introduce a new method ReflectionMethod->getOriginalClass() to retrieve it.
> >
> > class B {
> >   function f($x) {}
> > }
> > class C extends B {}
> >
> > foreach ([
> >   // There are different ways to get a reflection method object, all
> > of them track the original class.
> >   new ReflectionMethod('C', 'f'),
> >   (new ReflectionClass('C'))->getMethod('f'),
> >   (new ReflectionMethod('C', 'f'))->getParameters()[0]->getDeclaringFunction(),
> > ] as $rm) {
> >   // The following won't change:
> >   assert($rm->class === 'B');
> >   assert($rm->getDeclaringClass()->getName() === 'B');
> >   // New method:
> >   assert($rm->getOriginalClass()->getName() === 'C');
> >
> >
> > Alternatives
> > ==========
> >
> > At first I thought we might introduce a new class like
> > "VirtualReflectionMethod" which behaves as if the method was declared
> > on the child class. But this is awkward.
> >
> > I think the ->getOriginalClass() is much simpler.
>
>
> I would not be opposed to this.  I don't know that I have any use cases for it, but I'd be open to it.

You can search in your favourite project's /vendor/ directory for
methods with two or more parameters that receive reflector objects.

"function .*\(.*Reflection\w+ \$\w+, .?Reflection\w+ \$\w+"

>
> --Larry Garfield
>
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: https://www.php.net/unsub.php
>