Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:120439
Message-ID: <9ea3a5af-679d-ad63-f9c2-e0d8d148db3f@bastelstu.be>
Date: Mon, 29 May 2023 21:49:17 +0200
MIME-Version: 1.0
Content-Language: en-US
To: Go Kudo <g-kudo@colopl.co.jp>, internals@lists.php.net
References: <CAH5C8xWAsRV+8h-tZ2Xq0=tn753kbSQX=KSEYsE2fWEtQVMrew@mail.gmail.com>
 <CAMs36HfmXuUJWJ0uih+Pj_vui4wG4vy3OTMmmspGmpP9h_gvgw@mail.gmail.com>
In-Reply-To: <CAMs36HfmXuUJWJ0uih+Pj_vui4wG4vy3OTMmmspGmpP9h_gvgw@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Subject: Re: [PHP-DEV] [RFC] [Discussion] PHP 8.3 deprecations
From: tim@bastelstu.be (=?UTF-8?Q?Tim_D=c3=bcsterhus?=)

Hi

On 5/29/23 08:44, Go Kudo wrote:
> I realized I was about to add the deprecation of `lcg_value()` and forgot
> to do so, so I added it.
> 
> https://wiki.php.net/rfc/deprecations_php_8_3#global_combined_lcg
> 
> As usual, my English is of low quality, so I would appreciate it if you
> could point out any problems.

I think it's too early for that. Because:

1. The replacement is only available as of PHP 8.3. Thus there won't be 
a single version where "replacement is available" and "the function does 
not emit deprecation notices" is both true. It should be deprecated with 
PHP 8.4 at the earliest to give folks at least (!) one version to 
cleanly migrate existing code without suppressing any errors / notices / 
deprecations.

2. It's not seedable, thus the implementation can be switched to use a 
different engine without affecting existing code.

3. It's not as commonly misused as mt_rand() is. Primarily because the 
possible use-cases are much more rare.

Best regards
Tim Düsterhus