Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:120438
Content-Type: text/plain;
	charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.600.7\))
In-Reply-To: <e58dde83-654d-b0ad-de77-d0450a56ef75@bastelstu.be>
Date: Mon, 29 May 2023 21:34:21 +0200
Cc: PHP internals <internals@lists.php.net>
Content-Transfer-Encoding: quoted-printable
Message-ID: <91F5F43D-5A20-4B14-B2D1-475607021940@gmail.com>
References: <e58dde83-654d-b0ad-de77-d0450a56ef75@bastelstu.be>
To: =?utf-8?Q?Tim_D=C3=BCsterhus?= <tim@bastelstu.be>
Subject: Re: [PHP-DEV] RFC [Discussion]: Marking overridden methods
 (#[\Override])
From: claude.pache@gmail.com (Claude Pache)



> Le 11 mai 2023 =C3=A0 18:37, Tim D=C3=BCsterhus <tim@bastelstu.be> a =
=C3=A9crit :
>=20
> Hi
>=20
> I'm now opening discussion for the RFC "Marking overridden methods =
(#[\Override])":
>=20
> ----
>=20
> RFC: Marking overridden methods (#[\Override])
> https://wiki.php.net/rfc/marking_overriden_methods
>=20

Hi Tim,

One weakness of the proposal, is that there is no notice when a method =
without #[\Override] annotation accidentally overrides a parent method. =
This is necessary for the sake of BC, of course. Therefore, (inspired by =
the --noImplicitOverride flag of TypeScript), I suggest adding a =
complementary #[\NoImplicitOverride] annotation on the derived class, =
that makes #[\Override] mandatory on overriding methods. The following =
example would then trigger a compilation error since Laravel 5.4:

<?php

namespace App\Models;
=20
use Illuminate\Database\Eloquent\Model;
use Illuminate\Support\Facades\Http;
=20
#[\NoImplicitOverride] // <=3D=3D=3D=3D=3D=3D HERE
class RssFeed extends Model {
  /* Laravel 5.4 added the refresh() method to Eloquent, but we already
   * have a custom method with the same name and signature that does
   * something entirely different.
   */ =20
  public function refresh()
  {
    $this->message =3D Http::get($this->url);
    $this->save();
  }
}

?>

=E2=80=95Claude