Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:120435
Message-ID: <8d1da895-e5ac-15f7-d2f9-51d3a35dc63e@alec.pl>
Date: Mon, 29 May 2023 20:38:09 +0200
MIME-Version: 1.0
To: internals@lists.php.net
References: <CAH5C8xUn2wotLg0L7KZHoOGf3q-UqbL=47p2PLzK_mOBb=MJXQ@mail.gmail.com>
 <CAOWwgpncdhKvhwiAFUh_c_8+_vr=u9HhYxws_WZArh7W3Fi0xw@mail.gmail.com>
 <799ae864-6e25-4196-a5ce-0d74600a8378@app.fastmail.com>
 <CAAwdEzCbRdDHN=WYZy_jnyrM9USG9k9bxn=AW-KVWB8iSrBmrQ@mail.gmail.com>
 <CAOWwgp=Ch2iwOzxooiRcfk3WYMz-eYmQ51M-UP2Hh3bDogX5uw@mail.gmail.com>
 <CAH5C8xV76ou5Edpvq-vzb6RytW5-3uGanX+Sqf92-qnH26ccBw@mail.gmail.com>
 <6aa0a33e-8b9f-d96b-bc42-de3b5d85936e@alec.pl>
Content-Language: en-US
In-Reply-To: <6aa0a33e-8b9f-d96b-bc42-de3b5d85936e@alec.pl>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] [RFC] [Discussion] Clone with
From: alec@alec.pl (Aleksander Machniak)

On 29.05.2023 14:12, Aleksander Machniak wrote:
> In "Property name expressions" section's first code example I think you 
> intended to do `clone $self` (not `clone $this`) inside the foreach() loop.
> 
> Also, I have a feeling that it would be better to implement `clone 
> $object with $properties` syntax first and if that is accepted think 
> about expressions support. It's not a strong feeling though.

Actually, with some more thought, my opinion now is that introduction of 
property name expressions is not justified. And will be a reason for me 
to vote No.

I'm still not decided about which syntax I'd prefer, maybe you should do 
a poll with these basic options. Sorry, if there was one and I missed it.

1) clone $object with $properties;

2) clone($object, $properties);

3) clone($object, prop1: $var1, prop2: $var2);

4) clone($object, function ($clone) use ($properties) {
        foreach ($properties as $name => $value) {
            $clone->{$name} = $value;
        }
    });

5) clone $obj with (prop1: $var1, prop2: $var2);


note: $properties is iterable
note: in 2-4) brackets are potentially optional.
note: imho, 5) is similar to 3), but worse.

-- 
Aleksander Machniak
Kolab Groupware Developer        [https://kolab.org]
Roundcube Webmail Developer  [https://roundcube.net]
----------------------------------------------------
PGP: 19359DC1 # Blog: https://kolabian.wordpress.com