Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:120434
Message-ID: <5798AD17-3FA6-48E5-83E9-B5773BE94598@gmail.com>
Content-Type: multipart/alternative;
	boundary="Apple-Mail=_1BE4FD64-5C5F-48DD-8764-E82E04F870E8"
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.600.7\))
Date: Mon, 29 May 2023 20:35:29 +0200
In-Reply-To: <CAH5C8xXtCVHaxwzmAW_eBxp_D6p7kww9svND=3AEeC9X6--YXg@mail.gmail.com>
Cc: PHP Internals List <internals@lists.php.net>
To: =?utf-8?B?TcOhdMOpIEtvY3Npcw==?= <kocsismate90@gmail.com>
References: <CAH5C8xXtCVHaxwzmAW_eBxp_D6p7kww9svND=3AEeC9X6--YXg@mail.gmail.com>
Subject: Re: [PHP-DEV] [RFC] [Discussion] Deprecate functions with overloaded
 signatures
From: claude.pache@gmail.com (Claude Pache)

--Apple-Mail=_1BE4FD64-5C5F-48DD-8764-E82E04F870E8
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
	charset=utf-8



> Le 27 avr. 2023 =C3=A0 23:28, M=C3=A1t=C3=A9 Kocsis =
<kocsismate90@gmail.com> a =C3=A9crit :
>=20
> Hi Internals,
>=20
> As you have possibly already experienced, overloaded signatures cause
> various smaller and bigger issues, while the concept is not natively
> supported by PHP. That's why I drafted an RFC which intends to phase =
out
> the majority of overloaded function/method signatures and also forbid
> the introduction of such functions in the future:
> =
https://wiki.php.net/rfc/deprecate_functions_with_overloaded_signatures
>=20
>=20

Hi M=C3=A1t=C3=A9,

The replacement methods for IntlCalendar::set() (namely =
IntlCalendar::setDate() and IntlCalendar::setDateTime()) must not have a =
return type of `void`, but `true`, like the original method, for the two =
following reasons:

1. By changing the returned value, you are introducing an unnecessary =
hazard when migrating code.

2. Per https://www.php.net/IntlCalendar, all modification methods of =
that class (clear(), roll(), setTime(), etc.) consistently return `true` =
on success and `false` on failure, even when the method is infallible =
(and thus would always return `true`). Don=E2=80=99t break consistency.

=E2=80=94Claude



--Apple-Mail=_1BE4FD64-5C5F-48DD-8764-E82E04F870E8--