Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:120429
MIME-Version: 1.0
References: <CAH5C8xUn2wotLg0L7KZHoOGf3q-UqbL=47p2PLzK_mOBb=MJXQ@mail.gmail.com>
 <CAOWwgpncdhKvhwiAFUh_c_8+_vr=u9HhYxws_WZArh7W3Fi0xw@mail.gmail.com>
 <799ae864-6e25-4196-a5ce-0d74600a8378@app.fastmail.com> <CAAwdEzCbRdDHN=WYZy_jnyrM9USG9k9bxn=AW-KVWB8iSrBmrQ@mail.gmail.com>
 <CAOWwgp=Ch2iwOzxooiRcfk3WYMz-eYmQ51M-UP2Hh3bDogX5uw@mail.gmail.com>
 <CAH5C8xV76ou5Edpvq-vzb6RytW5-3uGanX+Sqf92-qnH26ccBw@mail.gmail.com> <CABdc3WqsVq4Jo1tt5EOevQ15aXhLA1+6SRmSENc8-K7SHX20Hg@mail.gmail.com>
In-Reply-To: <CABdc3WqsVq4Jo1tt5EOevQ15aXhLA1+6SRmSENc8-K7SHX20Hg@mail.gmail.com>
Date: Mon, 29 May 2023 09:59:33 -0500
Message-ID: <CAB_ngDjQ1zNS_mt6FOJOYuebep1eWBs2b5VSMQVx_LhUbngKsQ@mail.gmail.com>
To: php internals <internals@lists.php.net>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PHP-DEV] [RFC] [Discussion] Clone with
From: brandonja991@gmail.com (Brandon Jackson)

Hello everyone,

On Mon, May 29, 2023 at 6:48=E2=80=AFAM Micha=C5=82 Marcin Brzuchalski
<michal.brzuchalski@gmail.com> wrote:

> So there would be no option to vote on shorthand properties, right?
>
> Array syntax with all properties as strings in quotes probably means no
> support from IDE.
> I think this is a really bad move, I'd be against it.

I agree. I think going to a single syntax was a good move, but using the li=
teral
property name would have been better imo.

I really think the syntax would benefit from being more similar to
function calls,
with a syntax like:

clone $obj with (prop1: "value");

This brings the familiarity from named arguments, which in this case would
represent the object's properties.

Then for dynamic property name support, you can borrow array unpacking
into an argument list from function calls as well, allowing the dynamic
properties to be set like:

$myProp =3D 'prop1';
clone $obj with (...[$myProp =3D> 'value']);

This also gives the ability to have create dynamic properties via anonymous
function as well, like so:

$myFunc =3D function ($original): array {
    $props =3D [];
    // add results
    return $props;
};
clone $obj with (...$myFunc($obj));

You even have the ability to pass it whatever you want including the origin=
al
object to operate off of.

Regards,
Brandon Jackson