Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:120408
Date: Sat, 27 May 2023 22:10:15 +0100
To: internals@lists.php.net
User-Agent: K-9 Mail for Android
In-Reply-To: <CA+kxMuR=eRJr8za+f+QpQHWY9vSn1UtFm-Esb1Eya+1sNsqLCw@mail.gmail.com>
References: <e58dde83-654d-b0ad-de77-d0450a56ef75@bastelstu.be> <CADyq6sJ3aaipfagKtoqksOm2JFp-UN5H0hkrOndgKad2W9x3fg@mail.gmail.com> <CA+p1FabKB1K2P9ZidyNgva+mfe1xzTtracyKkQGFKeWYcW1+_Q@mail.gmail.com> <CA+kxMuRse5=y_+XKk1LyQ3MpkLan75DzbE=sxtmeiaZf7W0yLQ@mail.gmail.com> <CA+p1FaZmagr9Js_a2wp2SOrbhb-uZAhcknXKRLQHonw45gBBOg@mail.gmail.com> <CA+kxMuR=eRJr8za+f+QpQHWY9vSn1UtFm-Esb1Eya+1sNsqLCw@mail.gmail.com>
Message-ID: <13955358-2538-4DB5-BD8A-506AFC6F2D35@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain;
 charset=utf-8
Content-Transfer-Encoding: quoted-printable
Subject: =?US-ASCII?Q?Re=3A_=5BPHP-DEV=5D_RFC_=5BDiscussion=5D=3A_Mark?= =?US-ASCII?Q?ing_overridden_methods_=28=23=5B=5COverride=5D=29?=
From: rowan.collins@gmail.com (Rowan Tommins)

On 27 May 2023 11:40:44 BST, Dan Ackroyd <Danack@basereality=2Ecom> wrote:
>On Mon, 22 May 2023 at 22:32, David Gebler <davidgebler@gmail=2Ecom> wrot=
e:
>>
>> either you  use static analysis tools as part of your PHP workflow, bec=
ause
>> you care about that stuff, or you don't=2E
>
>I these words imply an unpleasant connotation; that people who don't
>use static analysis tools are bad people who don't care about their
>code=2E


That's not what was being said at all, as is clear a couple of sentences l=
ater:

> If you don't habitually use these tools already, you're probably not goi=
ng to be annotating your code with #[Override] anyway=2E


The claim being made was not about good or bad programmers, or whether the=
y *deserve* the benefit of the change; it was about whether it's likely tha=
t they'll *receive* the benefit of the change=2E=20

To rephrase, the proposal is for the engine to only warn about code where =
the attribute is present, not where it's absent, so for a user to benefit t=
hey have to edit their code to include it=2E If they edit their code and th=
en run a static analyser, they don't need the attribute to be built into th=
e engine; if they don't add it, the feature has zero benefit to them=2E

So the argument is that the key estimate for whether to include it in the =
engine is how many users will add the attribute, but not run a static analy=
sis tool=2E If that number is very low, adding it to the engine has a very =
low value=2E

Regards,

--=20
Rowan Tommins
[IMSoP]