Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:120393
Message-ID: <c2ea6b97-5ecd-ca12-c748-f0b5e37402c4@bastelstu.be>
Date: Tue, 23 May 2023 22:26:54 +0200
MIME-Version: 1.0
To: PHP internals <internals@lists.php.net>
References: <e58dde83-654d-b0ad-de77-d0450a56ef75@bastelstu.be>
 <CADyq6sJ3aaipfagKtoqksOm2JFp-UN5H0hkrOndgKad2W9x3fg@mail.gmail.com>
 <CA+p1FabKB1K2P9ZidyNgva+mfe1xzTtracyKkQGFKeWYcW1+_Q@mail.gmail.com>
 <CA+kxMuRse5=y_+XKk1LyQ3MpkLan75DzbE=sxtmeiaZf7W0yLQ@mail.gmail.com>
 <CA+p1FaZmagr9Js_a2wp2SOrbhb-uZAhcknXKRLQHonw45gBBOg@mail.gmail.com>
Content-Language: en-US
In-Reply-To: <CA+p1FaZmagr9Js_a2wp2SOrbhb-uZAhcknXKRLQHonw45gBBOg@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Subject: Re: [PHP-DEV] RFC [Discussion]: Marking overridden methods
 (#[\Override])
From: tim@bastelstu.be (=?UTF-8?Q?Tim_D=c3=bcsterhus?=)

Hi

On 5/22/23 23:32, David Gebler wrote:
> whether there's an appetite out there in general to start adding all sorts
> of new runtime checks, which I would argue means any new runtime check
> warrants the utmost consideration of cost-benefit.

Just to make sure there is no misunderstanding I'd like to clarify that 
the proposed check of this RFC is not a runtime error. It's a compile 
time error, just like the check for incompatible method signatures 
during inheritance. In fact it shares a non-trivial amount of the 
existing logic of that check, because it's so similar.

My understanding is that once the class is successfully sitting in 
Opcache there will not be any further overhead.

------

With regard to the rest of the email, I (naturally?) disagree that this 
should not be part of the language itself. I currently have less time 
available than expected, I'll put the email back on unread and hope to 
be able to give a more expanded and nuanced reply later. I just wanted 
to get the first part with regard to runtime vs. compile time out for now.

Best regards
Tim Düsterhus