Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:120386
MIME-Version: 1.0
References: <e58dde83-654d-b0ad-de77-d0450a56ef75@bastelstu.be>
In-Reply-To: <e58dde83-654d-b0ad-de77-d0450a56ef75@bastelstu.be>
Date: Mon, 22 May 2023 14:21:42 +0200
Message-ID: <CAPyj-LAgGmiiNiNCLhN4KN7H8tnBQd6Gkz=L6ajq+VQPjA7MqQ@mail.gmail.com>
To: PHP internals <internals@lists.php.net>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PHP-DEV] RFC [Discussion]: Marking overridden methods (#[\Override])
From: tovilo.ilija@gmail.com (Ilija Tovilo)

Hi Tim

On Thu, May 11, 2023 at 6:37=E2=80=AFPM Tim D=C3=BCsterhus <tim@bastelstu.b=
e> wrote:
> I'm now opening discussion for the RFC "Marking overridden methods
> (#[\Override])":
>
> RFC: Marking overridden methods (#[\Override])
> https://wiki.php.net/rfc/marking_overriden_methods

We've already talked in private, but let me state my position here as well.

The implementation is quite simple (~60 lines of non-whitespace,
non-generated C code), and does not introduce any new syntax that
parsers/static analyzers are *forced* to handle.

The RFC shows that there is a benefit for code using the attribute,
namely showing intent to the reader, reducing the risk of typos and
being more resistant to errors when refactoring / upgrading library
versions. Having the feature supported by the engine, while not
strictly necessary, allows users who don't use static analyzers to
profit from it, and define consistent semantics for static analyzers
to follow.

The benefits seem worth the maintenance cost, even if small for the
average user.

Ilija