Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:120376
Feedback-ID: i8414410d:Fastmail
User-Agent: Cyrus-JMAP/3.9.0-alpha0-431-g1d6a3ebb56-fm-20230511.001-g1d6a3ebb
Mime-Version: 1.0
Message-ID: <8b23cbe6-1c4d-40b6-a68b-780d5e8f9dbf@app.fastmail.com>
In-Reply-To: <4D8DE606-5E99-4D6F-962E-CBE1392C4B94@gmail.com>
References: <05b7e019-27d4-e6a9-2088-f712c22317a9@mabe.berlin>
 <CA+kxMuSP1TTB5141-5ePJWZT5_DZ8rCHvkh0ikKBcnXYSMV5zg@mail.gmail.com>
 <4D8DE606-5E99-4D6F-962E-CBE1392C4B94@gmail.com>
Date: Sun, 21 May 2023 10:20:57 -0500
To: "php internals" <internals@lists.php.net>
Content-Type: text/plain
Subject: Re: [PHP-DEV] rounding integers
From: larry@garfieldtech.com ("Larry Garfield")

On Sun, May 21, 2023, at 7:18 AM, Rowan Tommins wrote:
> On 21 May 2023 13:00:30 BST, Dan Ackroyd <Danack@basereality.com> wrote:
>>On Sun, 21 May 2023 at 06:16, Marc <marc@mabe.berlin> wrote:
>>>
>>> Do you think this could be an acceptable BC-break
>>
>>No. Suggesting changing a 30 year old maths operations is a huge BC break.
>>
>>> or should this be a different function?
>>
>>Just make your own that does precisely what you want...
>
> I agree on the first point, but disagree on the second. It's far too 
> late to change round() itself, but the lack of built-in functions for 
> converting to int in a controlled way is frustrating, particularly as 
> the fashion moves towards stronger typing in general.
>
> On the surface, it sounds like a trivial operation, but there's a lot 
> of edge cases to think about (limits of FP precision, negatives 
> including negative zero, etc), and shipping a robust implementation of 
> int_round, int_floor and int_ceil in core would save everyone having to 
> rediscover them the hard way.

Having recently been bitten by floor() returning a float even though the value that comes back is logically an int, I would be fully in support of "and returns an int" versions of these functions in core.

--Larry Garfield