Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:12034 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 64621 invoked by uid 1010); 9 Aug 2004 07:46:23 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 64597 invoked from network); 9 Aug 2004 07:46:22 -0000 Received: from unknown (HELO gw2.emini.dk) (192.38.9.232) by pb1.pair.com with SMTP; 9 Aug 2004 07:46:22 -0000 Received: from backup.intra.emini.dk (backup.intra.emini.dk [10.0.0.14]) by gw2.emini.dk (Postfix) with ESMTP id 2C0953B6DC; Mon, 9 Aug 2004 09:46:22 +0200 (CEST) Organization: Emini ApS To: internals@lists.php.net Date: Mon, 9 Aug 2004 09:46:21 +0200 User-Agent: KMail/1.6.2 Cc: Derick Rethans , Joe Orton References: <20040723211815.GB15309@redhat.com> <20040807160217.GA15321@redhat.com> In-Reply-To: X-NCC-RegID: dk.proventum MIME-Version: 1.0 Content-Disposition: inline Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-ID: <200408090946.21859.edink@emini.dk> Subject: Re: [PHP-DEV] [PATCH] fix symbol namespace pollution from bundled libgd From: edink@emini.dk (Edin Kadribasic) On Monday 09 August 2004 09:00, Derick Rethans wrote: > On Sat, 7 Aug 2004, Joe Orton wrote: > > That would mean adding exactly the reverse set of #defines to allow the > > the GD extension to be built against an external copy of libgd (which of > > course won't use the phpgd_* symbols). > > > > Given that a complete set of #defines is needed anyway, doing it without > > modifying libgd makes more sense since it's then easier to track the > > upstream libgd sources. > > Right ;-) Can you please update your patch with the new symbols then? > I'll commit it then later (or just ask for a CVS account!) I'm -1 on this patch. The problem is has existed for mysql lib for ages and for all other libraries used by PHP. A note in the documentation stating that if you want to use GD from PHP and another Apache module you need to compile PHP with the external library should be sufficient. I'm afraid that the maintenance of this patch would bring more hassle that the rare occasion where another apache module uses libgd. Edin