Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:120334
Message-ID: <1c09e0e8-a219-cf72-4e66-717dcf892db2@bastelstu.be>
Date: Thu, 18 May 2023 00:53:25 +0200
MIME-Version: 1.0
Content-Language: en-US
To: php@shyim.de
Cc: internals@lists.php.net
References: <4ECF6970-2A01-4C47-9B41-87D534F54CB8@shyim.de>
 <35a55420-5b12-c811-1ff4-c41d29f3a0c6@bastelstu.be>
 <EBED81F7-25BF-45A5-8751-B6E2BCE4B0AF@shyim.de>
In-Reply-To: <EBED81F7-25BF-45A5-8751-B6E2BCE4B0AF@shyim.de>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Subject: Re: [PHP-DEV] [RFC] path_join function
From: tim@bastelstu.be (=?UTF-8?Q?Tim_D=c3=bcsterhus?=)

Hi

Please do not "top-post". Instead reply inline and cut the quoted parts 
to a minimum.

On 5/17/23 23:49, php@shyim.de wrote:
> No stripping would be needed at the end :)

I don't follow then.

> Yes I would like to work on an proper RFC and make thoughts on the already given feedback here :)
> 

Okay, let me add some additional questions for you to already think about:

- Should the function perform file system operations? Why? Why not?
- What is with stuff like Windows network shares that, to my 
understanding, have multiple directory separators next to each other?
- Is the name of the function the best? I'd probably drop the 
underscore, because we already have 'pathinfo'.

I'd also like to use this opportunity to add a "+1" with regard to "make 
this a proper class for manipulating paths, similarly to Python's 
pathlib or so". I would find that much more useful than the proposed 
function.

Best regards
Tim Düsterhus