Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:120327
Return-Path: <tim@bastelstu.be>
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 9152 invoked from network); 17 May 2023 15:36:31 -0000
Received: from unknown (HELO php-smtp4.php.net) (45.112.84.5)
  by pb1.pair.com with SMTP; 17 May 2023 15:36:31 -0000
Received: from php-smtp4.php.net (localhost [127.0.0.1])
	by php-smtp4.php.net (Postfix) with ESMTP id 096E4180503
	for <internals@lists.php.net>; Wed, 17 May 2023 08:36:31 -0700 (PDT)
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on php-smtp4.php.net
X-Spam-Level: 
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS,
	T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.2
X-Spam-ASN: AS24940 176.9.0.0/16
X-Spam-Virus: No
X-Envelope-From: <tim@bastelstu.be>
Received: from chrono.xqk7.com (chrono.xqk7.com [176.9.45.72])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by php-smtp4.php.net (Postfix) with ESMTPS
	for <internals@lists.php.net>; Wed, 17 May 2023 08:36:30 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bastelstu.be;
	s=mail20171119; t=1684337788;
	bh=1rR6HP7t/y4ygQxmRwI6sgkwhMLsu/ZMMu5P6zQk9us=;
	h=Message-ID:Date:MIME-Version:Subject:To:References:From:
	 In-Reply-To:Content-Type:from:to:cc:subject:message-id;
	b=POHMaf3rHA4YwAX2tns1aszQMMtIQjfP5mnaywctM7ZwrKYS5PSn6AO/12YTJlOe3
	 R6iWWSPDJKY1949asZ8CxRVb6R/cOAT4No9ZIRisrY52mNuTf1kFd7e0AWzXxil31H
	 5WNNthl6SxDu8ZzSQj7ioDJhAQgaGOOo2o6Lpc1UlRMrtvt9X6tH+Mr4iUddP/UmUL
	 BYIxyQVf+mxadzRMZXrULV8D95nEpPFROjvAxxUt8uGskblZc95JK6xlXJtvNwofA8
	 5DDcVj+X4T4qpRmzthmv1ZIkDznlLRMPlPoZpOGBkBQFYKHpmawuUAi+6l4il4gAjR
	 pZLyBg0RvZHvA==
Message-ID: <35a55420-5b12-c811-1ff4-c41d29f3a0c6@bastelstu.be>
Date: Wed, 17 May 2023 17:36:25 +0200
MIME-Version: 1.0
Content-Language: en-US
To: php@shyim.de, internals@lists.php.net
References: <4ECF6970-2A01-4C47-9B41-87D534F54CB8@shyim.de>
In-Reply-To: <4ECF6970-2A01-4C47-9B41-87D534F54CB8@shyim.de>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Subject: Re: [PHP-DEV] [RFC] path_join function
From: tim@bastelstu.be (=?UTF-8?Q?Tim_D=c3=bcsterhus?=)

Hi

On 5/17/23 16:54, php@shyim.de wrote:
> When you concat just the paths you have to think about:
> - normalize string part to strip ending slash

Why is it necessary to strip the ending slash?

> - for windows compatibility you have to use DIRECTORY_SEPERATOR
> 

I don't use Windows, but to the best of my knowledge, using the '/' is 
equivalent to the backslash. Is there a case where the difference matters?

> I am really looking for your feedback, right now I have no “karma points” to create a RFC in the wiki :)
> 

If you want to proceed with an actual RFC, the folks handing out the RFC 
karma would need your Wiki name.

Best regards
Tim Düsterhus