Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:120325
MIME-Version: 1.0
References: <4ECF6970-2A01-4C47-9B41-87D534F54CB8@shyim.de>
In-Reply-To: <4ECF6970-2A01-4C47-9B41-87D534F54CB8@shyim.de>
Date: Wed, 17 May 2023 16:13:08 +0100
Message-ID: <CAMjSS5Nsq6uo=yagS+XmstqU3a4Tah-_Bc6G1KwZbzMuO8z3hw@mail.gmail.com>
Cc: internals@lists.php.net
Content-Type: multipart/alternative; boundary="00000000000044b6f505fbe5225c"
Subject: Re: [PHP-DEV] [RFC] path_join function
From: ttijhof@wikimedia.org (Timo Tijhof)

--00000000000044b6f505fbe5225c
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

In case it is of interest, the implementation we use on Wikipedia
as part of MediaWiki, is available on Packagist:

https://packagist.org/packages/wikimedia/relpath
https://www.mediawiki.org/wiki/RelPath

--
Timo Tijhof,
Wikimedia Foundation.
https://timotijhof.net/



On Wed, May 17, 2023 at 3:54=E2=80=AFPM <php@shyim.de> wrote:

> Hey,
>
> I have created on GitHub a feature request for a path_join function (
> https://github.com/php/php-src/issues/11258) and got the label that this
> requires a RFC. So I am here now :)
>
> The idea is to provide in PHP itself a function to join filesystem paths
> (idea: path_join) like in other languages, node as example (
> https://nodejs.org/api/path.html#pathjoinpaths). For me this function is
> some kind of base filesystem functionality like basename, realpath.
>
> Example usage:
>
> path_join('/base', 'my', 'path'); // /base/my/path
> path_join('/base', 'my', 'path', 'test', '..'); // /base/my/path
>
> Why not just string concatenation?
>
> When you concat just the paths you have to think about:
> - normalize string part to strip ending slash
> - for windows compatibility you have to use DIRECTORY_SEPERATOR
>
> I think this can improve the developer experience when working with
> filesystems a lot and people can delete their implementation.
>
> I am really looking for your feedback, right now I have no =E2=80=9Ckarma=
 points=E2=80=9D
> to create a RFC in the wiki :)
>
> Thanks,
> Soner

--00000000000044b6f505fbe5225c--